44333[TASK] Use b/w manual icons in Extension Manager
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Daniel Goerz +1
-
Verified V +2
- Stefan Neufeind +2
- Daniel Goerz +1
Issues 1
Files 2
Review log 17
-
Xavier Perseguers uploaded patch set 1 10/28/15, 15:11
-
Wouter Wolters commented on patch set 1 10/28/15, 15:13
FormatsViewHelper.php:86$iconHtmlFormatsViewHelper.php:95$iconHtml -
Xavier Perseguers uploaded patch set 2 10/28/15, 15:14
-
Wouter Wolters voted on patch set 2 CR +1 10/28/15, 15:15
-
Andreas Kienast voted on patch set 2 CR +1 V +1 10/28/15, 16:01
-
Xavier Perseguers commented on patch set 2 V -1 10/28/15, 16:39
it does not work properly when not having EXT:sphinx loaded -
Stefan Neufeind commented on patch set 2 V +1 10/28/15, 16:49
With sphinx it worked for me. Without I had blue SXW-icons for non-core-extensions still shipping SXW. -
Xavier Perseguers uploaded patch set 3 10/28/15, 16:50
-
Stefan Neufeind voted on patch set 3 CR +1 V +1 10/28/15, 16:55
-
Stefan Neufeind commented on patch set 3 10/28/15, 16:56
work with EXT:sphinx (new icons) and without (using sxw-icons for some non-core-extensions) -
Benjamin Kott commented on patch set 3 CR -1 V -1 10/28/15, 17:37
sorry this is not the correct namespace for action icons, all action icons have to start with - "actions-" and have to be present in the icon repository else we will never be able to clean this up. please create an issue for every icon you need https://github.com/wmdbsystems/T3.Icons/issues so we can do a new release after and the icons have been created -
Xavier Perseguers commented on patch set 3 10/28/15, 22:19
@Benjamin, please see https://github.com/wmdbsystems/T3.Icons/issues/243, https://github.com/wmdbsystems/T3.Icons/issues/244, https://github.com/wmdbsystems/T3.Icons/issues/245 and https://github.com/wmdbsystems/T3.Icons/issues/246. I let you give feedback and hopefully adapt this patch after that since you better know what to do. -
Xavier Perseguers uploaded patch set 4 10/30/15, 14:21
-
Stefan Neufeind voted on patch set 4 CR +1 V +1 10/30/15, 17:35
-
Daniel Goerz voted on patch set 4 CR +1 V +1 10/30/15, 17:47
-
Stefan Neufeind voted on patch set 4 CR +2 V +2 10/30/15, 17:48
-
Stefan Neufeind merged patch set 4 10/30/15, 17:48
FormatsViewHelper.php:83