Review main Merged

44333[TASK] Use b/w manual icons in Extension Manager

Xavier Perseguers CR +2 V +2 Normal +40 −12 updated 10/30/15, 17:48

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel Goerz +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel Goerz +1

Issues 1

Files 2

Review log 17

  1. Xavier Perseguers uploaded patch set 1 10/28/15, 15:11

  2. Wouter Wolters commented on patch set 1 10/28/15, 15:13

    FormatsViewHelper.php:83

    $iconHtml

    FormatsViewHelper.php:86

    $iconHtml

    FormatsViewHelper.php:95

    $iconHtml
  3. Xavier Perseguers uploaded patch set 2 10/28/15, 15:14

  4. Wouter Wolters voted on patch set 2 CR +1 10/28/15, 15:15

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 10/28/15, 16:01

  6. Xavier Perseguers commented on patch set 2 V -1 10/28/15, 16:39

    it does not work properly when not having EXT:sphinx loaded
  7. Stefan Neufeind commented on patch set 2 V +1 10/28/15, 16:49

    With sphinx it worked for me. Without I had blue SXW-icons for non-core-extensions still shipping SXW.
  8. Xavier Perseguers uploaded patch set 3 10/28/15, 16:50

  9. Stefan Neufeind voted on patch set 3 CR +1 V +1 10/28/15, 16:55

  10. Stefan Neufeind commented on patch set 3 10/28/15, 16:56

    work with EXT:sphinx (new icons) and without (using sxw-icons for some non-core-extensions)
  11. Benjamin Kott commented on patch set 3 CR -1 V -1 10/28/15, 17:37

    sorry this is not the correct namespace for action icons, all action icons have to start with - "actions-" and have to be present in the icon repository else we will never be able to clean this up. please create an issue for every icon you need https://github.com/wmdbsystems/T3.Icons/issues so we can do a new release after and the icons have been created
  12. Xavier Perseguers commented on patch set 3 10/28/15, 22:19

  13. Xavier Perseguers uploaded patch set 4 10/30/15, 14:21

  14. Stefan Neufeind voted on patch set 4 CR +1 V +1 10/30/15, 17:35

  15. Daniel Goerz voted on patch set 4 CR +1 V +1 10/30/15, 17:47

  16. Stefan Neufeind voted on patch set 4 CR +2 V +2 10/30/15, 17:48

  17. Stefan Neufeind merged patch set 4 10/30/15, 17:48