Review main Merged

44342[BUGFIX] Repair EditDocumentController in FE edit scope

Andreas Kienast CR +2 V +2 Easy +43 −6 updated 10/29/15, 17:13

Commit message

This patch repairs the EditDocumentController when called by FE edit.
The main issue was that JavaScripts depends on global objects in ``top``
which are set by BackendController that is only called when one acts
in the fully bootstrapped backend view.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Christian Kuhn +1
  • Verified V +2
    • Morton Jonuschat +2
    • Christian Kuhn +1

Issues 1

Files 4

Review log 11

  1. Andreas Kienast uploaded patch set 1 10/28/15, 23:27

  2. Andreas Kienast uploaded patch set 2 10/29/15, 08:48

  3. Andreas Kienast uploaded patch set 3 10/29/15, 08:49

  4. Andreas Kienast uploaded patch set 4 10/29/15, 08:50

  5. Morton Jonuschat uploaded patch set 5 10/29/15, 11:40

  6. Morton Jonuschat voted on patch set 5 CR +1 V +1 10/29/15, 11:41

  7. Christian Kuhn commented on patch set 5 CR -1 10/29/15, 16:00

    i'd like to have a slightly better encapsulation here. andy will improve this a bit.
  8. Andreas Kienast uploaded patch set 6 10/29/15, 17:02

  9. Christian Kuhn voted on patch set 6 CR +1 V +1 10/29/15, 17:05

  10. Morton Jonuschat voted on patch set 6 CR +2 V +2 10/29/15, 17:13

  11. Morton Jonuschat merged patch set 6 10/29/15, 17:13