Review main Merged

44350[TASK] Allow to define multiple DataHandler commands for one element

Oliver Hader CR +2 V +2 Normal +63 −66 updated 11/05/15, 11:40

Commit message

The method DataHandler::process_cmdmap currently allows only one command
to be executed for one element. A command-map like the following is
currently not possible - the second command would be ignored:

[tt_content][13][localize] = 1
[tt_content][13][inlineLocalizeSynchronize] = children:14

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 6

  1. Oliver Hader uploaded patch set 1 10/29/15, 12:36

  2. Stefan Neufeind commented on patch set 1 CR +1 V +1 10/31/15, 19:18

    Don't have a testcase for the multiple commands at hand. But the basics still work as before, tests run fine, fine by reading.
  3. Stefan Neufeind uploaded patch set 2 10/31/15, 19:42

  4. Stefan Neufeind commented on patch set 2 CR +1 V +1 10/31/15, 19:43

    sorry, pushed it again by accident
  5. Benni Mack voted on patch set 2 CR +2 V +2 11/05/15, 08:14

  6. Benni Mack merged patch set 2 11/05/15, 11:40