Review main Merged

44355[BUGFIX] Do not render empty help button

Andreas Kienast CR +2 V +2 Easy +6 −4 updated 10/29/15, 14:34

Commit message

Currently, if EXT:cshmanual is not installed, an empty help button
gets rendered. This patch changes the return value of
BackendUtility::wrapInHelp() and checks for an empty string in
HelpButton.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Wouter Wolters +1
  • Verified V +2
    • Morton Jonuschat +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 5

  1. Andreas Kienast uploaded patch set 1 10/29/15, 14:17

  2. Andreas Kienast updated the commit message in patch set 2 10/29/15, 14:19

  3. Wouter Wolters voted on patch set 2 V +1 CR +1 10/29/15, 14:20

  4. Morton Jonuschat voted on patch set 2 CR +2 V +2 10/29/15, 14:34

  5. Morton Jonuschat merged patch set 2 10/29/15, 14:34