44365[BUGFIX] Use correct backend layout in FE
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stefan Neufeind +1
- Georg Ringer +1
-
Verified V +2
- Markus Klein +2
- Stefan Neufeind +1
- Georg Ringer +1
- Wolfgang Wagner +1
Issues 1
Files 1
Review log 21
-
Markus Klein uploaded patch set 1 10/29/15, 17:31
-
Markus Klein commented on patch set 1 10/29/15, 17:32
@Wolfgang: Please quickly test the patch if it works. Thanks -
Markus Klein updated the commit message in patch set 2 10/29/15, 17:52
-
Daniel Goerz commented on patch set 2 10/29/15, 21:14
ContentObjectRenderer.php:5952Where does this sentence continue? :) -
Markus Klein commented on patch set 2 10/29/15, 21:18
ContentObjectRenderer.php:5952Replyin another file :D -
Markus Klein uploaded patch set 3 10/29/15, 21:20
-
Daniel Goerz voted on patch set 3 CR +1 10/29/15, 21:21
-
Stefan Neufeind commented on patch set 3 10/29/15, 23:03
While reading I wondered: Why can't we use backend_layout_next_level from the root page? Also during testing take into account that we only have 1 page (the root-page) or two (current and root). -
Alexander Opitz commented on patch set 3 10/30/15, 09:02
ContentObjectRenderer.php:5955$rootLine = array_slice ($tsfe->rootLine , 1, -1); ?? -
Alexander Opitz commented on patch set 3 10/30/15, 09:07
And me too, I don#t understand, why root isn't taken into account. -
Stefan Neufeind commented on patch set 3 CR -1 10/30/15, 09:13
So -1 for the moment then imho. But not really just for this patch then - it would already be wrong in the place where this code comes from. @Markus: Do you know why root was excluded? -
Markus Klein commented on patch set 3 10/30/15, 11:14
If I'm not mistaken, the root page (uid 0) is included too in that array, which obviously has no backend_layout info. -
Wolfgang Wagner commented on patch set 3 V +1 11/02/15, 09:09
Works for me -
Wolfgang Wagner commented on patch set 3 V -1 11/02/15, 10:30
Sorry, does not work correctly. As Stefan said, backend_layout_next_level is not used. Saw that too late. -
Markus Klein uploaded patch set 4 11/07/15, 12:07
-
Markus Klein commented on patch set 4 11/07/15, 12:09
Verified that now. The rootline here does not contain the uid=0 page which is the case on the other class. Should work now. -
Wolfgang Wagner voted on patch set 4 V +1 11/07/15, 19:27
-
Stefan Neufeind commented on patch set 4 CR +1 V +1 11/07/15, 21:44
quite obvious. page['backend_layout'] is the current page and backend_layout_next_level may only be fetched from one level higher. -
Georg Ringer voted on patch set 4 CR +1 V +1 11/09/15, 04:03
-
Markus Klein voted on patch set 4 CR +2 V +2 11/09/15, 11:21
-
Gerrit merged patch set 4 11/09/15, 11:21