Review main Merged

44365[BUGFIX] Use correct backend layout in FE

Markus Klein CR +2 V +2 Easy +5 −1 updated 11/09/15, 11:21

Commit message

Skip unqualified pages for backend layout determination.
This is basically a copy of the code already present in
BackendLayoutView::getSelectedCombinedIdentifier().

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Georg Ringer +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Wolfgang Wagner +1

Issues 1

Files 1

Review log 21

  1. Markus Klein uploaded patch set 1 10/29/15, 17:31

  2. Markus Klein commented on patch set 1 10/29/15, 17:32

    @Wolfgang: Please quickly test the patch if it works. Thanks
  3. Markus Klein updated the commit message in patch set 2 10/29/15, 17:52

  4. Daniel Goerz commented on patch set 2 10/29/15, 21:14

    ContentObjectRenderer.php:5952

    Where does this sentence continue? :)
  5. Markus Klein commented on patch set 2 10/29/15, 21:18

    ContentObjectRenderer.php:5952 Reply

    in another file :D
  6. Markus Klein uploaded patch set 3 10/29/15, 21:20

  7. Daniel Goerz voted on patch set 3 CR +1 10/29/15, 21:21

  8. Stefan Neufeind commented on patch set 3 10/29/15, 23:03

    While reading I wondered: Why can't we use backend_layout_next_level from the root page? Also during testing take into account that we only have 1 page (the root-page) or two (current and root).
  9. Alexander Opitz commented on patch set 3 10/30/15, 09:02

    ContentObjectRenderer.php:5955

    $rootLine = array_slice ($tsfe->rootLine , 1, -1); ??
  10. Alexander Opitz commented on patch set 3 10/30/15, 09:07

    And me too, I don#t understand, why root isn't taken into account.
  11. Stefan Neufeind commented on patch set 3 CR -1 10/30/15, 09:13

    So -1 for the moment then imho. But not really just for this patch then - it would already be wrong in the place where this code comes from. @Markus: Do you know why root was excluded?
  12. Markus Klein commented on patch set 3 10/30/15, 11:14

    If I'm not mistaken, the root page (uid 0) is included too in that array, which obviously has no backend_layout info.
  13. Wolfgang Wagner commented on patch set 3 V +1 11/02/15, 09:09

    Works for me
  14. Wolfgang Wagner commented on patch set 3 V -1 11/02/15, 10:30

    Sorry, does not work correctly. As Stefan said, backend_layout_next_level is not used. Saw that too late.
  15. Markus Klein uploaded patch set 4 11/07/15, 12:07

  16. Markus Klein commented on patch set 4 11/07/15, 12:09

    Verified that now. The rootline here does not contain the uid=0 page which is the case on the other class. Should work now.
  17. Wolfgang Wagner voted on patch set 4 V +1 11/07/15, 19:27

  18. Stefan Neufeind commented on patch set 4 CR +1 V +1 11/07/15, 21:44

    quite obvious. page['backend_layout'] is the current page and backend_layout_next_level may only be fetched from one level higher.
  19. Georg Ringer voted on patch set 4 CR +1 V +1 11/09/15, 04:03

  20. Markus Klein voted on patch set 4 CR +2 V +2 11/09/15, 11:21

  21. Gerrit merged patch set 4 11/09/15, 11:21