Review main Merged

44366[TASK] Disable save button after submit

Andreas Kienast CR +2 V +2 Easy +20 −2 updated 10/29/15, 19:30

Commit message

To prevent multiple form submission in EditDocumentController the save
split button gets disabled after the first submit. To visualize activity,
the disk icon gets replaced by a spinner after submit.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Mathias Schreiber +1
  • Verified V +2
    • Morton Jonuschat +2
    • Mathias Schreiber +1

Issues 1

Files 2

Review log 19

  1. Andreas Kienast uploaded patch set 1 10/29/15, 17:38

  2. Andreas Kienast voted on patch set 1 V -1 10/29/15, 17:48

  3. Andreas Kienast uploaded patch set 2 10/29/15, 17:50

  4. Morton Jonuschat voted on patch set 2 CR +1 V +1 10/29/15, 17:53

  5. Mathias Schreiber commented on patch set 2 CR +1 V +1 10/29/15, 18:23

    remember hard-reloading the BE
  6. Andreas Kienast commented on patch set 2 CR -1 10/29/15, 18:24

    on it
  7. Andreas Kienast uploaded patch set 3 10/29/15, 18:27

  8. Andreas Kienast updated the commit message in patch set 4 10/29/15, 18:28

  9. Mathias Schreiber commented on patch set 4 CR +1 V +1 10/29/15, 18:31

    better
  10. Andreas Kienast uploaded patch set 5 10/29/15, 18:48

  11. Morton Jonuschat commented on patch set 5 CR -1 10/29/15, 18:52

    Andy is working on it
  12. Andreas Kienast uploaded patch set 6 10/29/15, 19:07

  13. Mathias Schreiber voted on patch set 6 CR +1 V +1 10/29/15, 19:07

  14. Andreas Kienast commented on patch set 6 CR -1 V -1 10/29/15, 19:08

    SplitButtons.js:57

    goddammit
  15. Andreas Kienast uploaded patch set 7 10/29/15, 19:09

  16. Morton Jonuschat voted on patch set 7 CR +1 V +1 10/29/15, 19:11

  17. Mathias Schreiber voted on patch set 7 CR +1 V +1 10/29/15, 19:14

  18. Morton Jonuschat voted on patch set 7 CR +2 V +2 10/29/15, 19:30

  19. Morton Jonuschat merged patch set 7 10/29/15, 19:30