Review main Merged

44389[TASK] Remove documentTemplate sections TypoScriptTemplateObjectBrowse

Ruud Silvrants CR +2 V +2 Easy +22 −14 updated 10/30/15, 16:30

Commit message

Remove documentTemplate sections calls for
TypoScriptTemplateObjectBrowserModuleFunctionController

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Gernot Schulmeister +1
  • Verified V +2
    • Christian Kuhn +2
    • Gernot Schulmeister +1

Issues 1

Files 1

Review log 12

  1. Ruud Silvrants uploaded patch set 1 10/30/15, 11:01

  2. Gernot Schulmeister updated the commit message in patch set 2 10/30/15, 11:58

  3. Gernot Schulmeister commented on patch set 2 CR +1 V -1 10/30/15, 12:00

    The forge ticket number is missing, otherwise the typoscript object browser is ok for me after the changes
  4. Ruud Silvrants uploaded patch set 3 10/30/15, 12:24

  5. Gernot Schulmeister commented on patch set 3 CR +1 V +1 10/30/15, 12:50

    ok now :-)
  6. Ruud Silvrants uploaded patch set 4 10/30/15, 15:00

  7. Gernot Schulmeister commented on patch set 4 CR -1 V -1 10/30/15, 15:48

    TypoScriptTemplateObjectBrowserModuleFunctionController.php:511

    as far as I see this ll call should also be escaped? -> true
  8. Gernot Schulmeister uploaded patch set 5 10/30/15, 15:50

  9. Ruud Silvrants uploaded patch set 6 10/30/15, 15:51

  10. Gernot Schulmeister voted on patch set 6 CR +1 V +1 10/30/15, 15:57

  11. Christian Kuhn voted on patch set 6 CR +2 V +2 10/30/15, 16:30

  12. Christian Kuhn merged patch set 6 10/30/15, 16:30