44397[BUGFIX] respectSubmittedDataValue false has to load property value with Form ViewHelpers
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Sebastian Fischer +1
- Andreas Kienast +1
-
Verified V +2
- Oliver Hader +2
- Andreas Kienast +1
Issues 1
Files 2
Review log 19
-
Andreas Allacher uploaded patch set 1 10/30/15, 13:15
-
Andreas Allacher updated the commit message in patch set 2 11/04/15, 06:59
-
Michael Oehlhof commented on patch set 2 CR +1 11/04/15, 22:24
Little typo -
Andreas Allacher commented on patch set 2 11/05/15, 08:35
Thx for changing the commit message -
Michael Oehlhof commented on patch set 2 11/05/15, 16:00
I haven't change the commit message, I only comment the typo. -
Andreas Allacher updated the commit message in patch set 3 11/05/15, 16:47
-
Andreas Allacher commented on patch set 3 11/05/15, 16:47
I thought you did because of the +1 but true. Now fixed it -
Nicole Hummel commented on patch set 3 11/09/15, 22:53
Can we add an Unit Test for that case? -
Andreas Allacher uploaded patch set 4 11/10/15, 06:44
-
Andreas Allacher commented on patch set 4 11/10/15, 06:45
@Nicole: Added a unit test. However, I noticed that the new getValueAttribute is in general missing a lot of tests that exists for the old getValue method. Maybe we should create a task to add all the other tests in the future? -
Andreas Allacher uploaded patch set 5 11/10/15, 06:45
-
Andreas Kienast commented on patch set 5 CR +1 V +1 11/10/15, 07:05
Verified by unit tests -
Sebastian Fischer voted on patch set 5 CR +1 11/10/15, 07:15
-
Oliver Hader voted on patch set 5 CR +1 11/10/15, 09:20
-
Oliver Hader voted on patch set 5 CR +2 V +2 11/10/15, 11:55
-
Nicole Hummel commented on patch set 5 11/10/15, 12:00
AbstractFormFieldViewHelperTest.php:58why don't you use the setRespectSubmittedDataValue here?AbstractFormFieldViewHelperTest.php:71$formViewHelper->setArguments()? -
Andreas Allacher commented on patch set 5 11/10/15, 12:11
AbstractFormFieldViewHelperTest.php:58ReplyAs _set('arguments', ...) is used here and in the other tests, I think it is better to keep this and modify all tests accordingly in another patch?AbstractFormFieldViewHelperTest.php:71ReplyCopied from the other unit tests in this class wanted to use the same structure. -
Oliver Hader commented on patch set 5 11/10/15, 12:21
I opt for taking the change now and adjust unit tests later... -
Gerrit merged patch set 5 11/10/15, 12:21