Review main Merged

44401[BUGFIX] Escape vsprintf placeholders properly

Mathias Schreiber CR +2 V +2 Easy +1 −1 updated 10/30/15, 17:31

Commit message

Percentage characters were not properly encoded leading
to a warning in the FormatDetailsVH

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 7

  1. Mathias Schreiber uploaded patch set 1 10/30/15, 13:57

  2. Xavier Perseguers commented on patch set 1 10/30/15, 14:10

    ErrorHandler.php:200

    For me that's not the correct place to fix the problem, you should not have to know how the value you want to send to the DB will be processed in another method.
  3. Wouter Wolters commented on patch set 1 10/30/15, 14:18

  4. Xavier Perseguers commented on patch set 1 10/30/15, 14:22

    ErrorHandler.php:200 Reply

    Just proceed then, but this does not mean that I agree with the other fix either :)
  5. Wouter Wolters voted on patch set 1 V +1 CR +1 10/30/15, 14:23

  6. Stefan Neufeind commented on patch set 1 V +2 CR +2 10/30/15, 17:31

    ErrorHandler.php:200 Reply

    But you know you are writing "something with placeholders". Maybe the placeholder-concept in itself is not too elegant - but that needs a different approach then.
  7. Stefan Neufeind merged patch set 1 10/30/15, 17:31