44401[BUGFIX] Escape vsprintf placeholders properly
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Wouter Wolters +1
-
Verified V +2
- Stefan Neufeind +2
- Wouter Wolters +1
Issues 1
Files 1
Review log 7
-
Mathias Schreiber uploaded patch set 1 10/30/15, 13:57
-
Xavier Perseguers commented on patch set 1 10/30/15, 14:10
-
Wouter Wolters commented on patch set 1 10/30/15, 14:18
ErrorHandler.php:200ReplyThis is the same fix as in: https://review.typo3.org/#/c/18762/2/typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php -
Xavier Perseguers commented on patch set 1 10/30/15, 14:22
ErrorHandler.php:200ReplyJust proceed then, but this does not mean that I agree with the other fix either :) -
Wouter Wolters voted on patch set 1 V +1 CR +1 10/30/15, 14:23
-
Stefan Neufeind commented on patch set 1 V +2 CR +2 10/30/15, 17:31
ErrorHandler.php:200ReplyBut you know you are writing "something with placeholders". Maybe the placeholder-concept in itself is not too elegant - but that needs a different approach then. -
Stefan Neufeind merged patch set 1 10/30/15, 17:31
ErrorHandler.php:200