Review main Merged

44404[TASK] Add 'form' attribute to ModuleTemplate buttons

Andreas Kienast CR +2 V +2 Easy +41 −6 updated 10/31/15, 14:22

Commit message

This patch adds support for "form" attributes to the buttons used by the
ModuleTemplate API as buttons aren't enforced to be in <form> tags anymore
in HTML5.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1

Issues 1

Files 5

Review log 7

  1. Andreas Kienast uploaded patch set 1 10/30/15, 14:03

  2. Andreas Kienast commented on patch set 1 CR -2 10/30/15, 14:04

  3. Andreas Kienast commented on patch set 1 CR 0 10/30/15, 16:36

    Ready for review
  4. Stefan Neufeind commented on patch set 1 10/30/15, 17:11

    requisite 44403 merged meanwhile
  5. Mathias Schreiber voted on patch set 1 CR +1 V +1 10/31/15, 14:15

  6. Christian Kuhn commented on patch set 1 CR +2 V +2 10/31/15, 14:22

    cool thing :)
  7. Christian Kuhn merged patch set 1 10/31/15, 14:22