Review main Merged

44405[BUGFIX] EXT:form - Having only a FILEUPLOAD element breaks form

Ralf Zimmermann CR +2 V +2 Easy +4 −1 updated 10/31/15, 11:41

Commit message

The FILEUPLOAD data is stored in the session data. The confirmation page
does not create a hidden input element for it. That is the problem.
Solution: extend the detection of the submitted form with a
session lookup.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Björn Jacob +1
  • Verified V +2
    • Christian Kuhn +2
    • Björn Jacob +1

Issues 1

Files 1

Review log 5

  1. Ralf Zimmermann uploaded patch set 1 10/30/15, 14:06

  2. Björn Jacob updated the commit message in patch set 2 10/30/15, 21:01

  3. Björn Jacob commented on patch set 2 CR +1 V +1 10/30/15, 21:01

    Works as expected with supplied form.
  4. Christian Kuhn voted on patch set 2 CR +2 V +2 10/31/15, 11:41

  5. Christian Kuhn merged patch set 2 10/31/15, 11:41