Review main Abandoned

44421[BUGFIX] Enable sorting of records by the label of foreign_table

Jan Helke CR 0 V 0 Easy +21 −4 updated 11/20/15, 12:57

Commit message

The patch changes the sorting of records in the list view so that
the sorting is no longer done by the uid of the foreign table but
the label (commonly the title).

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 15

  1. Jan Helke uploaded patch set 1 10/30/15, 17:42

  2. Michael Oehlhof commented on patch set 1 CR -1 10/30/15, 20:52

    AbstractDatabaseRecordList.php:12

    ??? What does this variable here?
  3. Jan Helke uploaded patch set 2 10/31/15, 10:17

  4. Jan Helke commented on patch set 1 10/31/15, 10:18

    AbstractDatabaseRecordList.php:12 Reply

    Done
  5. Michael Oehlhof voted on patch set 2 CR +1 V +1 10/31/15, 10:44

  6. Wouter Wolters commented on patch set 2 CR -1 10/31/15, 10:48

    AbstractDatabaseRecordList.php:650

    foreignTable

    AbstractDatabaseRecordList.php:651

    foreignTableLabel

    AbstractDatabaseRecordList.php:655

    move this outside foreach. Space missing after comma

    AbstractDatabaseRecordList.php:659

    space missing after comma
  7. Wouter Wolters uploaded patch set 3 10/31/15, 13:53

  8. Wouter Wolters voted on patch set 3 CR +1 10/31/15, 13:53

  9. Jan Helke uploaded patch set 4 10/31/15, 14:09

  10. Jan Helke commented on patch set 2 10/31/15, 14:10

    AbstractDatabaseRecordList.php:650 Reply

    Done

    AbstractDatabaseRecordList.php:651 Reply

    Done

    AbstractDatabaseRecordList.php:655 Reply

    Done

    AbstractDatabaseRecordList.php:659 Reply

    Done
  11. Morton Jonuschat uploaded patch set 5 10/31/15, 14:52

  12. Gernot Schulmeister commented on patch set 5 CR -1 V -1 10/31/15, 15:02

    Throws database error because $addWhere does not come with the table prefixed and then for example sys_language_uid is ambiguous
  13. Jan Helke commented on patch set 5 11/06/15, 17:19

    Yes. But I see no reasonable way to clean any 'addWhere' statement from andy TCA. So the only possibility I see, is to only apply this patch, if no addWhere is given. But this smells very fishy.
  14. Morton Jonuschat commented on patch set 5 CR -1 V -1 11/13/15, 13:03

    @Jan: Don't think this is easily fixable and I agree that a half baked solution that just works for cases without "addWhere" feels wrong. Should abandon this and close the issue as 'won't fix'?
  15. Jan Helke abandoned the change 11/20/15, 12:57

    Not fixable in this way due to the possibility of TCA injections.