44424[TASK] Rename variable $P to $wizardParameters
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Andreas Kienast +1
- Michael Oehlhof +1
-
Verified V +2
- Christian Kuhn +2
- Andreas Kienast +1
- Michael Oehlhof +1
Issues 1
Files 1
Review log 7
-
Gernot Schulmeister uploaded patch set 1 10/30/15, 18:18
-
Andreas Kienast voted on patch set 1 CR +1 V +1 10/30/15, 18:26
-
Michael Oehlhof commented on patch set 1 CR -1 V -1 10/30/15, 18:37
There is one usage of the variable P left in the code. EXT:extensionmanager/Classes/ViewHelpers/Form/TypoScriptContantsViewHelper.php Line 112 -
Gernot Schulmeister commented on patch set 1 10/31/15, 10:02
The usage in EXT:extensionmanager/Classes/ViewHelpers/Form/TypoScriptContantsViewHelper.php Line 112 generates a Get Parameter which was not changed in sysext/backend/Classes/Controller/Wizard/ColorpickerController.php Line 139, so there should not be a problem, but I was not able to test the TypoScriptContantsViewHelper, is there an example usage anywhere? -
Michael Oehlhof commented on patch set 1 CR +1 V +1 10/31/15, 10:12
You are right, it is not a problem. -
Christian Kuhn voted on patch set 1 CR +2 V +2 10/31/15, 10:16
-
Christian Kuhn merged patch set 1 10/31/15, 10:16