Review main Merged

44432[BUGFIX] Assure correct INCLUDE_TYPOSCRIPT with relative paths on subpages

Daniel Goerz CR +2 V +2 Easy +10 −2 updated 11/26/15, 11:44

Commit message

If a subpage has a template that clears the setup, INCLUDE_TYPOSCRIPT
will not work with relative paths anymore. This patch assures that always
the correct file is included.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Mathias Schreiber +1
    • Markus Klein +1
  • Verified V +2
    • Stefan Neufeind +2
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 9

  1. Daniel Goerz uploaded patch set 1 10/31/15, 13:46

  2. Markus Klein updated the commit message in patch set 2 10/31/15, 13:50

  3. Markus Klein commented on patch set 2 CR +1 10/31/15, 13:50

    Wow, very nice catch!
  4. Mathias Schreiber voted on patch set 2 CR +1 V +1 10/31/15, 18:39

  5. Stefan Neufeind commented on patch set 2 10/31/15, 18:58

    just a sec, testing (since I have that broken testcase here)
  6. Stefan Neufeind commented on patch set 2 CR +2 V +2 10/31/15, 19:01

    Well done, works. We discoverd the issue while playing a bit, and Daniel nailed it right away. Great.
  7. Stefan Neufeind merged patch set 2 10/31/15, 19:01

  8. Marc Bastian Heinrichs commented on patch set 3 11/26/15, 11:23

    6.2 is also affected. Please backport.
  9. Stefan Neufeind commented on patch set 3 11/26/15, 11:44

    Proposed for 6.2 at https://review.typo3.org/44952