Review main Merged

44445[TASK] Remove last DocumentTemplate section calls

Wouter Wolters CR +2 V +2 Easy +10 −9 updated 10/31/15, 19:17

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Morton Jonuschat +1
  • Verified V +2
    • Christian Kuhn +2
    • Morton Jonuschat +1

Issues 1

Files 3

Review log 7

  1. Wouter Wolters uploaded patch set 1 10/31/15, 16:19

  2. Morton Jonuschat voted on patch set 1 CR +1 V +1 10/31/15, 16:22

  3. Christian Kuhn commented on patch set 1 10/31/15, 17:08

    if section() and sectionHeader() (?) are unused now, we can *remove* these methods from ModuleTemplate and *deprecate* them in DocumentTemplate.
  4. Stefan Neufeind commented on patch set 1 10/31/15, 19:13

    @Christian: used in a lot of places with moduleTemplate. There is still one comment pointing to $this->doc->section() in typo3/sysext/backend/Classes/Module/ModuleSettings.php
  5. Wouter Wolters commented on patch set 1 10/31/15, 19:14

    Lets get this in. I'm working on the rest in another patch.
  6. Christian Kuhn voted on patch set 1 CR +2 V +2 10/31/15, 19:17

  7. Christian Kuhn merged patch set 1 10/31/15, 19:17