Review main Merged

44458[TASK] Remove usage of modTmpl->setForm from ScheduleModuleController

Jan Helke CR +2 V +2 Easy +7 −2 updated 10/31/15, 23:54

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Gernot Schulmeister +1
    • Michael Oehlhof +1
  • Verified V +2
    • Christian Kuhn +2
    • Gernot Schulmeister +1
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 7

  1. Jan Helke uploaded patch set 1 10/31/15, 18:45

  2. Michael Oehlhof commented on patch set 1 CR -1 10/31/15, 18:49

    SchedulerModuleController.php:157

    Shouldn't it be id="SchedulerForm"? In the other patches always UpperCamelCase is used for th id.
  3. Jan Helke commented on patch set 1 10/31/15, 22:17

    The form had this id before the Patch. I introduced the ids only for forms, where no id was given. And I didn't want to change the name to avoid problems.
  4. Michael Oehlhof voted on patch set 1 CR +1 V +1 10/31/15, 22:18

  5. Gernot Schulmeister voted on patch set 1 CR +1 V +1 10/31/15, 22:47

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 10/31/15, 23:54

  7. Christian Kuhn merged patch set 1 10/31/15, 23:54