Review main Merged

44461[TASK] Remove usage of setForm from TypoScriptTemplateModuleController

Jan Helke CR +2 V +2 Easy +8 −4 updated 11/01/15, 20:14

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Gernot Schulmeister +1
    • Michael Oehlhof +1
  • Verified V +2
    • Benni Mack +2
    • Gernot Schulmeister +1
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 10

  1. Jan Helke uploaded patch set 1 10/31/15, 19:03

  2. Michael Oehlhof commented on patch set 1 10/31/15, 19:07

    TypoScriptTemplateModuleController.php:214

    Shouldn't this also be removed and replaced by a H2 tag?
  3. Michael Oehlhof commented on patch set 1 10/31/15, 19:20

    I mean H1 not H2
  4. Gernot Schulmeister commented on patch set 1 10/31/15, 19:23

    TypoScriptTemplateModuleController.php:214

    according to Lolli it will be removed with another task
  5. Christian Kuhn commented on patch set 1 V -1 10/31/15, 19:27

    breaks "click here to create extension template"
  6. Jan Helke uploaded patch set 2 10/31/15, 23:35

  7. Michael Oehlhof voted on patch set 2 CR +1 V +1 11/01/15, 08:44

  8. Gernot Schulmeister voted on patch set 2 CR +1 V +1 11/01/15, 09:20

  9. Benni Mack voted on patch set 2 CR +2 V +2 11/01/15, 20:14

  10. Benni Mack merged patch set 2 11/01/15, 20:14