Review main Merged

44465[TASK] Remove ModuleTemplate section calls

Wouter Wolters CR +2 V +2 Normal +68 −107 updated 11/06/15, 19:31

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Mathias Schreiber +1
    • Markus Sommer +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
    • Markus Sommer +1
    • Christian Kuhn +1

Issues 1

Files 19

Review log 20

  1. Wouter Wolters uploaded patch set 1 10/31/15, 19:55

  2. Wouter Wolters commented on patch set 1 10/31/15, 19:56

    sysext/dbal/Classes/Controller/ModuleController.php:105: $this->content .= $this->moduleTemplate->section( sysext/dbal/Classes/Controller/ModuleController.php:112: $this->content .= $this->moduleTemplate->section( sysext/dbal/Classes/Controller/ModuleController.php:119: $this->content .= $this->moduleTemplate->section( sysext/scheduler/Classes/Controller/SchedulerModuleController.php:312: return $this->moduleTemplate->section($sectionTitle, '<div class="tx_scheduler_mod1">' . $content . '</div>', false, true); sysext/compatibility6/Classes/Controller/Wizard/FormsController.php:226: $this->content .= $this->doc->section($this->getLanguageService()->getLL('forms_title'), $this->formsWizard(), 0, 1); sysext/compatibility6/Classes/Controller/Wizard/FormsController.php:228: $this->content .= $this->doc->section($this->getLanguageService()->getLL('forms_title'), '<span class="text-danger">' . $this->getLanguageService()->getLL('table_noData', 1) . '</span>', 0, 1); sysext/core/Classes/Database/QueryView.php:333: $output .= $GLOBALS['SOBE']->getModuleTemplate()->section('Load/Save Query', $this->makeStoreControl(), 0, 1); sysext/core/Classes/Database/QueryView.php:346: $output .= '<div id="query"></div>' . $GLOBALS['SOBE']->getModuleTemplate()->section('Make query', $tmpCode, 0, 1); sysext/core/Classes/Database/QueryView.php:365: $output .= $GLOBALS['SOBE']->getModuleTemplate()->section('SQL query', $this->tableWrap(htmlspecialchars($qExplain)), 0, 1); sysext/core/Classes/Database/QueryView.php:370: $output .= $GLOBALS['SOBE']->getModuleTemplate()->section('SQL error', $out, 0, 1); sysext/core/Classes/Database/QueryView.php:374: $output .= $GLOBALS['SOBE']->getModuleTemplate()->section($cPR['header'], $cPR['content'], 0, 1); sysext/func/Classes/Controller/PageFunctionsController.php:130: $this->content .= $this->moduleTemplate->section('', $vContent); sysext/info/Classes/Controller/InfoModuleController.php:122: $this->content .= $this->moduleTemplate->section('', $vContent); sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php:250: $this->content .= $this->moduleTemplate->section('', '<p class="lead">' . $lang->getLL('overview') . '</p>' . $table); sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php:493: $theOutput .= $this->moduleTemplate->section( sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php:499: $theOutput .= $this->moduleTemplate->section( sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php:510: $theOutput .= $this->moduleTemplate->section(
  3. Stefan Neufeind commented on patch set 1 10/31/15, 20:09

    remaining from https://review.typo3.org/44445: There is still one comment pointing to $this->doc->section() in typo3/sysext/backend/Classes/Module/ModuleSettings.php
  4. Michael Oehlhof uploaded patch set 2 10/31/15, 21:49

  5. Wouter Wolters uploaded patch set 3 11/02/15, 21:14

  6. Daniel Goerz voted on patch set 3 CR +1 11/03/15, 20:55

  7. Mathias Schreiber commented on patch set 3 CR -1 V -1 11/04/15, 20:28

    Section only OPENS a div. The first couple of files open and close a div at the same time resulting in broken HTML. I will take a look at this on friday
  8. Daniel Goerz voted on patch set 3 CR 0 11/04/15, 20:48

  9. Wouter Wolters abandoned the change 11/04/15, 23:30

  10. Wouter Wolters restored the change 11/05/15, 07:36

    whoops, no need for abandoning..
  11. Wouter Wolters commented on patch set 3 11/05/15, 08:05

    To be correct here. This patch is correct, it even fixes broken HTML. You will see broken HTML easier with this patch. The problem is that there is not a starting <body> tag!!
  12. Wouter Wolters commented on patch set 3 CR -1 11/05/15, 20:42

    I had a look again and found several unrelated HTML errors (see inline comments).

    CreateFolderController.php:202

    form tag should be closed within this div

    NewRecordController.php:587

    closing </ul> missing here

    RteController.php:230

    form tag not closed here
  13. Wouter Wolters uploaded patch set 4 11/05/15, 20:42

  14. Markus Sommer commented on patch set 4 CR +1 V +1 11/06/15, 10:56

    Looks and works good. Only the comment "// ERROR:" is strange

    RteController.php:218

    Error?
  15. Mathias Schreiber voted on patch set 4 CR +1 V +1 11/06/15, 15:40

  16. Stefan Neufeind voted on patch set 4 CR +1 11/06/15, 17:41

  17. Christian Kuhn voted on patch set 4 CR +1 11/06/15, 19:15

  18. Christian Kuhn voted on patch set 4 V +1 11/06/15, 19:22

  19. Wouter Wolters voted on patch set 4 V +2 CR +2 11/06/15, 19:31

  20. Wouter Wolters merged patch set 4 11/06/15, 19:31