Review main Merged

44469[BUGFIX] EXT:install: Upgrade wizard sys_file_processedfile no longer failed

Michael Oehlhof CR +2 V +2 Easy +5 −1 updated 11/03/15, 22:31

Commit message

The upgrade wizard failed if a storage driver was unavailable.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 8

  1. Michael Oehlhof uploaded patch set 1 11/01/15, 09:50

  2. Nicole Hummel voted on patch set 1 CR +1 V +1 11/03/15, 20:27

  3. Daniel Goerz voted on patch set 1 CR +1 11/03/15, 20:45

  4. Nicole Hummel commented on patch set 1 CR 0 V 0 11/03/15, 20:55

    IMHO catching \InvalidArgumentException is more accurate here. Testing it
  5. Nicole Hummel uploaded patch set 2 11/03/15, 21:29

  6. Nicole Hummel voted on patch set 2 CR +1 V +1 11/03/15, 21:29

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 11/03/15, 22:31

  8. Christian Kuhn merged patch set 2 11/03/15, 22:31