Review main Abandoned

44473[TASK] UTF8filesystem defaults now default for new installations

Stefan Neufeind CR 0 V 0 Easy +10 −1 updated 03/05/16, 21:54

Commit message

Most current Unix/Linux-like systems as well as all recent
Windows-versions nowadays usually use UTF8.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 8

  1. Stefan Neufeind uploaded patch set 1 11/01/15, 18:38

  2. Björn Jacob commented on patch set 1 CR -1 11/02/15, 05:45

    Important-60366-UTF8filesystemDefaultsNowDefaultForNewInstallations.rst:9

    Wouldn't it be better to have a line break after 76 signs (or 74, always confused which one to use...)?
  3. Stefan Neufeind commented on patch set 1 11/02/15, 06:15

    Important-60366-UTF8filesystemDefaultsNowDefaultForNewInstallations.rst:9 Reply

    This is exactly how the RST-generator at https://forger.typo3.org/standard/rst generates it. If there should be wrapping for long lines, do it there. Afaik we don't insert line-wraps in the RST.
  4. Björn Jacob commented on patch set 1 CR 0 11/02/15, 21:45

    Okay, I'm always doing the line break. So I'm confused. Sry for giving -1. Will test the patchset tomorrow.
  5. Martin Kutschker commented on patch set 1 CR +1 11/21/15, 14:23

    Looks good but plz fix the header of the documentation

    Important-60366-UTF8filesystemDefaultsNowDefaultForNewInstallations.rst:2

    UTF8filesystem defaults now to true for new installations or UTF8filesystem set to on now for new installations
  6. Frank Nägler commented on patch set 1 12/14/15, 13:08

    +1 for the change in general, but two things: 1) The rst should be a breaking rst file, because it is breaking for older systems 2) This patch can only go into v8, not for v7 anymore
  7. Jigal van Hemert commented on patch set 1 CR -2 01/13/16, 19:39

    Sorry for the -2, but this won't work reliably. This requires a valid setting for systemLocale, but there is no known way to find a UTF-8 locale which is installed in the system. There are many dozens of locale names used in all kinds of operating systems. It is not unlikely that there is no active UTF-8 locale and that one must be activated first. Turning the UTF-8 file system setting off at least ensures that files get a name with only ASCII characters and that file processing works. Many simple PHP functions like dirname() and basename() are locale aware; we've already created wrapper functions to make sure the systemLocale is active when using these functions. A good alternative could be to ask the user during installation for an installed locale to activate the UTF-8 file system setting. If no locale is given (or if the given locale is not present) the option can be set to false to make sure a working system is installed.

    DefaultConfiguration.php:106

    This requires a valid systemLocale for operations on files with non-ASCII characters in the path/name!
  8. Benni Mack abandoned the change 03/05/16, 21:54

    I will abandon this patch for now (we could revive it later) but UTF-8 is just not detectable reliably, and the patchset really lacks activity. It's done around 20% IMHO, much more work to do.