Review main Merged

44477[BUGFIX] Adodb PHP7 Redefinition of parameter $owner

Christian Kuhn CR +2 V +2 Easy +31 −5 updated 11/02/15, 12:25

Commit message

Adodb contains two methods that declare parameter $owner twice.
The PHP 7 linter fatals with this. A fix was merged to upstream
with commit ae85debec8 on https://github.com/ADOdb/ADOdb/ but not
released yet. The patch picks this part from the patch.

In result only linter warnings are left for old constructors in
openid and adodb, so travis-ci is green on PHP7 and can be removed
from "allowed_failures".

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Mathias Schreiber +1
    • Wouter Wolters +1

Issues 1

Files 5

Review log 6

  1. Christian Kuhn uploaded patch set 1 11/02/15, 12:16

  2. Christian Kuhn commented on patch set 1 11/02/15, 12:17

    catharsis with the adodb change applied goes green for PHP 7: https://travis-ci.org/lolli42/TYPO3.CMS-Catharsis/builds/88768713
  3. Wouter Wolters commented on patch set 1 V +1 CR +1 11/02/15, 12:18

    Checked your catharsis to validate PHP7
  4. Mathias Schreiber commented on patch set 1 CR +1 V +1 11/02/15, 12:24

    *tok tok tok
  5. Andreas Kienast voted on patch set 1 CR +2 V +2 11/02/15, 12:25

  6. Andreas Kienast merged patch set 1 11/02/15, 12:25