Review main Merged

44480[FEATURE] Add FlashMessage support to ModuleTemplate API

Andreas Kienast CR +2 V +2 Normal +75 −1 updated 11/02/15, 18:09

Commit message

Flash messages have different queues, depending on in which context they
are enqueued. The FlashMessageService defaults the queue to
``core.template.flashMessages``, Extbase defaults the queue to
``extbase.flashmessages.$randomPluginQueue``.

Add support for flash messages to ModuleTemplate which makes it possible
to enforce a queue identifier which is rendered in a global scope.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1

Issues 1

Files 3

Review log 11

  1. Andreas Kienast uploaded patch set 1 11/02/15, 16:50

  2. Andreas Kienast uploaded patch set 2 11/02/15, 16:52

  3. Frank Nägler commented on patch set 2 11/02/15, 17:17

    Feature-71251-AddFlashMessageSupportInModuleTemplateAPI.rst:24

    ;
  4. Wouter Wolters commented on patch set 2 CR -1 11/02/15, 17:37

    ModuleTemplate.php:831

    use short version
  5. Frank Nägler uploaded patch set 3 11/02/15, 17:46

  6. Frank Nägler commented on patch set 2 11/02/15, 17:46

    ModuleTemplate.php:831 Reply

    Done

    Feature-71251-AddFlashMessageSupportInModuleTemplateAPI.rst:24 Reply

    Done
  7. Frank Nägler voted on patch set 3 CR +1 V +1 11/02/15, 17:46

  8. Mathias Schreiber uploaded patch set 4 11/02/15, 17:50

  9. Mathias Schreiber commented on patch set 4 CR +1 V +1 11/02/15, 17:56

    @Wouter, wanna check again?
  10. Frank Nägler voted on patch set 4 CR +2 V +2 11/02/15, 18:09

  11. Frank Nägler merged patch set 4 11/02/15, 18:09