Review main Merged

44489[TASK] Deprecate several methods in DocumentTemplate

Wouter Wolters CR +2 V +2 Normal +37 −139 updated 01/07/16, 19:42

Commit message

Deprecated functions:

section
divider
sectionHeader
sectionBegin
sectionEnd

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Georg Ringer +1

Issues 1

Files 3

Review log 22

  1. Wouter Wolters uploaded patch set 1 11/02/15, 21:45

  2. Wouter Wolters updated the commit message in patch set 2 11/02/15, 21:47

  3. Wouter Wolters abandoned the change 11/04/15, 23:31

  4. Wouter Wolters restored the change 11/05/15, 07:37

  5. Wouter Wolters uploaded patch set 3 11/10/15, 07:49

  6. Mathias Schreiber voted on patch set 3 CR +1 V +1 11/10/15, 09:00

  7. Wouter Wolters commented on patch set 3 CR -2 11/10/15, 09:07

    To dangereuos to merge this late for 7LTS. Will be done within version 8
  8. Patrick Schriner commented on patch set 3 11/10/15, 10:19

    > To dangereuos to merge this late for 7LTS. Will be done within > version 8 A "light" version of this patch would be ok, wouldn't it? Deprecation only?
  9. Wouter Wolters commented on patch set 3 11/10/15, 10:20

    No, because the core itself uses deprecated functions and that is a blocker.
  10. Christian Kuhn commented on patch set 3 11/10/15, 11:14

    ok, so goal is to have this class fully deprecated then with 8, so it will be unused in 8 and can rot around until 9. that's fine.
  11. Oliver Eglseder commented on patch set 3 11/12/15, 22:03

    @Wouter phpstorm did not find any usages of the removed/deprecated methods. Is it missing something?
  12. Wouter Wolters commented on patch set 3 11/12/15, 22:18

    see inline comment

    DocumentTemplate.php:996

    this method is deprecated and shout not be used anymore.
  13. Wouter Wolters uploaded patch set 4 01/05/16, 17:50

  14. Wouter Wolters uploaded patch set 5 01/05/16, 17:52

  15. Wouter Wolters voted on patch set 5 CR 0 01/05/16, 17:56

  16. Michael Oehlhof commented on patch set 5 01/06/16, 09:57

    One little typo

    Deprecation-71260-DocumentTemplateMethods.rst:20

    aforementioned
  17. Wouter Wolters wrote 01/06/16, 09:59

    Patch set 6: Published edit on patch set 5.
  18. Georg Ringer voted on patch set 6 CR +1 V +1 01/07/16, 05:01

  19. Mathias Schreiber voted on patch set 6 CR +1 V +1 01/07/16, 08:06

  20. Oliver Klee voted on patch set 6 CR +1 01/07/16, 12:12

  21. Benni Mack voted on patch set 6 CR +2 V +2 01/07/16, 19:42

  22. Gerrit merged patch set 6 01/07/16, 19:42