44489[TASK] Deprecate several methods in DocumentTemplate
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mathias Schreiber +1
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2
- Benni Mack +2
- Mathias Schreiber +1
- Georg Ringer +1
Issues 1
Files 3
Review log 22
-
Wouter Wolters uploaded patch set 1 11/02/15, 21:45
-
Wouter Wolters updated the commit message in patch set 2 11/02/15, 21:47
-
Wouter Wolters abandoned the change 11/04/15, 23:31
-
Wouter Wolters restored the change 11/05/15, 07:37
-
Wouter Wolters uploaded patch set 3 11/10/15, 07:49
-
Mathias Schreiber voted on patch set 3 CR +1 V +1 11/10/15, 09:00
-
Wouter Wolters commented on patch set 3 CR -2 11/10/15, 09:07
To dangereuos to merge this late for 7LTS. Will be done within version 8 -
Patrick Schriner commented on patch set 3 11/10/15, 10:19
> To dangereuos to merge this late for 7LTS. Will be done within > version 8 A "light" version of this patch would be ok, wouldn't it? Deprecation only? -
Wouter Wolters commented on patch set 3 11/10/15, 10:20
No, because the core itself uses deprecated functions and that is a blocker. -
Christian Kuhn commented on patch set 3 11/10/15, 11:14
ok, so goal is to have this class fully deprecated then with 8, so it will be unused in 8 and can rot around until 9. that's fine. -
Oliver Eglseder commented on patch set 3 11/12/15, 22:03
@Wouter phpstorm did not find any usages of the removed/deprecated methods. Is it missing something? -
Wouter Wolters commented on patch set 3 11/12/15, 22:18
see inline commentDocumentTemplate.php:996this method is deprecated and shout not be used anymore. -
Wouter Wolters uploaded patch set 4 01/05/16, 17:50
-
Wouter Wolters uploaded patch set 5 01/05/16, 17:52
-
Wouter Wolters voted on patch set 5 CR 0 01/05/16, 17:56
-
Michael Oehlhof commented on patch set 5 01/06/16, 09:57
One little typoDeprecation-71260-DocumentTemplateMethods.rst:20aforementioned -
Wouter Wolters wrote 01/06/16, 09:59
Patch set 6: Published edit on patch set 5. -
Georg Ringer voted on patch set 6 CR +1 V +1 01/07/16, 05:01
-
Mathias Schreiber voted on patch set 6 CR +1 V +1 01/07/16, 08:06
-
Oliver Klee voted on patch set 6 CR +1 01/07/16, 12:12
-
Benni Mack voted on patch set 6 CR +2 V +2 01/07/16, 19:42
-
Gerrit merged patch set 6 01/07/16, 19:42