Review main Merged

44498[TASK] Move openid compatiblity config to extension

Helmut Hummel CR +2 V +2 Normal +44 −32 updated 11/03/15, 13:41

Commit message

To prepare extraction from the core, the compatibility
configuration needs to move into the extension itself.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 5

Review log 6

  1. Helmut Hummel uploaded patch set 1 11/03/15, 10:03

  2. Markus Klein commented on patch set 1 11/03/15, 10:05

    -1 actually. I don't want this to be loaded by default in a new installation. This is simply a breaking change.
  3. Helmut Hummel commented on patch set 1 11/03/15, 13:03

    > -1 actually. I don't want this to be loaded by default in a new installation. This is simply a breaking change. As maintainer of the extension later on you can decide how to handle this. For the core, this is the cleanest solution imho before extraction. These few classes also do not harm to have them in the alias map
  4. Markus Klein commented on patch set 1 CR +1 V +1 11/03/15, 13:23

    lets proceed
  5. Wouter Wolters voted on patch set 1 V +2 CR +2 11/03/15, 13:41

  6. Wouter Wolters merged patch set 1 11/03/15, 13:41