Review main Merged

44516[TASK] Auto-generate LegacyClassesForIde from alias map file

Helmut Hummel CR +2 V +2 Impossible +8769 −6093 updated 11/04/15, 08:31

Commit message

Add support for namespace aliases.
Generator: https://gist.github.com/helhum/c582225f8397310a59e0

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +2
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 9

  1. Helmut Hummel uploaded patch set 1 11/03/15, 15:41

  2. Helmut Hummel uploaded patch set 2 11/03/15, 15:46

  3. Mathias Brodala commented on patch set 2 11/03/15, 15:58

    LegacyClassesForIde.php:4

    Uhm, what?

    LegacyClassesForIde.php:6

    What is this namespace wrap used for?
  4. Helmut Hummel commented on patch set 2 11/03/15, 20:18

    LegacyClassesForIde.php:4 Reply

    This file is for IDEs only. It must not be executed otherwise

    LegacyClassesForIde.php:6 Reply

    the empty declaration is there because no code is allowed without namespace declaration. And we need the namespace declaration for namespaced aliases
  5. Christian Kuhn voted on patch set 2 CR +2 V +2 11/03/15, 20:29

  6. Wouter Wolters voted on patch set 2 CR +1 11/03/15, 20:42

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 11/03/15, 21:51

  8. Wouter Wolters merged patch set 2 11/03/15, 21:51

  9. Mathias Brodala commented on patch set 3 11/04/15, 08:31

    @Helmut, thanks.