44516[TASK] Auto-generate LegacyClassesForIde from alias map file
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +2
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +2
Issues 1
Files 2
Review log 9
-
Helmut Hummel uploaded patch set 1 11/03/15, 15:41
-
Helmut Hummel uploaded patch set 2 11/03/15, 15:46
-
Mathias Brodala commented on patch set 2 11/03/15, 15:58
LegacyClassesForIde.php:6What is this namespace wrap used for? -
Helmut Hummel commented on patch set 2 11/03/15, 20:18
LegacyClassesForIde.php:4ReplyThis file is for IDEs only. It must not be executed otherwiseLegacyClassesForIde.php:6Replythe empty declaration is there because no code is allowed without namespace declaration. And we need the namespace declaration for namespaced aliases -
Christian Kuhn voted on patch set 2 CR +2 V +2 11/03/15, 20:29
-
Wouter Wolters voted on patch set 2 CR +1 11/03/15, 20:42
-
Wouter Wolters voted on patch set 2 V +2 CR +2 11/03/15, 21:51
-
Wouter Wolters merged patch set 2 11/03/15, 21:51
-
Mathias Brodala commented on patch set 3 11/04/15, 08:31
@Helmut, thanks.
LegacyClassesForIde.php:4