Review main Merged

44529[BUGFIX] Fluid: form.hidden ViewHelper needs to respect submitted data

Andreas Allacher CR +2 V +2 Easy +1 −0 updated 11/10/15, 12:22

Commit message

As hidden fields might be modified via e.g. JavaScript
they also have to respect submitted data upon submit.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Christian Kuhn +1
    • Sebastian Fischer +1
    • Andreas Kienast +1
  • Verified V +2
    • Oliver Hader +2
    • Sebastian Fischer +1

Issues 1

Files 1

Review log 14

  1. Andreas Allacher uploaded patch set 1 11/04/15, 06:54

  2. Andreas Allacher uploaded patch set 2 11/04/15, 06:56

  3. Andreas Kienast commented on patch set 3 11/10/15, 07:03

    Published edit on patch set 2
  4. Andreas Kienast voted on patch set 3 CR +1 11/10/15, 07:03

  5. Sebastian Fischer voted on patch set 3 CR +1 11/10/15, 07:10

  6. Sebastian Fischer voted on patch set 3 V +1 11/10/15, 07:28

  7. Oliver Hader commented on patch set 3 CR +1 11/10/15, 09:28

    I'm wondering whether the initial change introducing the respectSubmittedDataValue behavior makes sense like that. It just changed the order of processing - but deprecated methods and introduced now ones, forgetting these kind of things... This means: Should "respectSubmittedDataValue" be the default behavior generally?
  8. Andreas Allacher commented on patch set 3 11/10/15, 11:41

    From what I understand only if you want submitted value on error to be the submitted value. Previously the in case the value attribute was set that one was used instead. Also what I am not completely sure about is why now addAdditionalIdentityPropertiesIfNeeded is not called anymore but I guess that is now handled differently?
  9. Andreas Allacher commented on patch set 3 11/10/15, 11:45

    EDIT from previous comment :) From what I understand only if you want the submitted value to be kept on error. Apparently before the change when you submitted the form and used value="foo" then the value of the value attribute was used, even if it might have been modified. But I don't think that was an issue if one used objects with property path prior to that change. However, I don't see many use cases for respectSubmittedValue = false, after all it would mean on error the value is overridden with the initial value. Except maybe PasswordViewHelper. Also what I am not completely sure about is why now addAdditionalIdentityPropertiesIfNeeded is not called anymore but I guess that is now handled differently?
  10. Christian Kuhn commented on patch set 3 11/10/15, 11:59

    hmmm, as long as the current bugfix fixes the issue i rather tend to accept the fix and maybe think about the whole thing later again?
  11. Andreas Allacher commented on patch set 3 11/10/15, 12:05

    agreed. especially with LTS releasedate today :)
  12. Christian Kuhn voted on patch set 3 CR +1 11/10/15, 12:19

  13. Oliver Hader voted on patch set 3 CR +2 V +2 11/10/15, 12:22

  14. Gerrit merged patch set 3 11/10/15, 12:22