Review main Merged

44550[TASK] TCA, type=select: Add missing renderTypes

Stefan Neufeind CR +2 V +2 Normal +54 −0 updated 11/05/15, 22:40

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 22

Show 2 more files

Review log 16

  1. Stefan Neufeind uploaded patch set 1 11/05/15, 11:41

  2. Wouter Wolters commented on patch set 1 CR -1 11/05/15, 11:43

    TcaSelectItems.php:41

    not needed IMO, we have this handled in TcaMigration class
  3. Stefan Neufeind commented on patch set 1 11/05/15, 11:43

    I was under the impression that we had a fallback for type=select without a renderType. But one not-updated extension showed me we don't. How about we add a fallback but mark it as deprecated? Also there are some renderType-settings missing in core. For some unit-tests imho we don't need it and maybe we can also leave out some included in this review. Haven't re-run the functionals yet.
  4. Christian Kuhn voted on patch set 1 CR -1 11/05/15, 11:43

  5. Morton Jonuschat commented on patch set 1 CR -1 11/05/15, 11:45

  6. Stefan Neufeind uploaded patch set 2 11/05/15, 11:54

  7. Stefan Neufeind commented on patch set 2 11/05/15, 11:55

    TcaMigration for type=select works if EXT:compatibility6 is enabled. Thanks for the hint. But we still should consider adding missing renderType-settings.
  8. Christian Kuhn commented on patch set 2 11/05/15, 12:14

    TcaMigration works always in bootstrap. you only need compat6 loaded if you still have tca in ext_tables.php ... see the according .rst file for more information.
  9. Christian Kuhn commented on patch set 2 CR -1 11/05/15, 12:23

    why are you adding these blindly without thinking about it and having the direct necessity?

    DatabaseRecordTypeValueTest.php:367

    not needed here.

    DatabaseRecordTypeValueTest.php:399

    not needed here.

    TcaInlineConfigurationTest.php:453

    is this needed?
  10. Stefan Neufeind commented on patch set 2 11/05/15, 15:49

    Just for the record: The TcaMigration works clean, even without compatibility6. The problem was an extension doing crazy stuff to define TCA - which worked but passed the TcaMigration unchanged. It was the extensions fault though. Thanks Lolli for direct feedback on the TcaMigration.
  11. Stefan Neufeind uploaded patch set 3 11/05/15, 16:24

  12. Stefan Neufeind commented on patch set 3 11/05/15, 16:25

    removed the unittest-related stuff since that doesn't "render" something (but the functionals do)
  13. Christian Kuhn commented on patch set 3 11/05/15, 21:45

    AbstractFormElement.php:386

    +1
  14. Christian Kuhn voted on patch set 3 V +1 CR +1 11/05/15, 22:15

  15. Wouter Wolters voted on patch set 3 V +2 CR +2 11/05/15, 22:40

  16. Wouter Wolters merged patch set 3 11/05/15, 22:40