44550[TASK] TCA, type=select: Add missing renderTypes
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 22
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php1+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_hotel.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_offer.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_price.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_hotel.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_offer.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_price.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel_offer_rel.php+4 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_offer.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_price.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel_offer_rel.php+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_offer.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_hotel.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_offer.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_price.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel.php+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel_rel.php+4 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/ext_tables.php+1 −0
Review log 16
-
Stefan Neufeind uploaded patch set 1 11/05/15, 11:41
-
Wouter Wolters commented on patch set 1 CR -1 11/05/15, 11:43
-
Stefan Neufeind commented on patch set 1 11/05/15, 11:43
I was under the impression that we had a fallback for type=select without a renderType. But one not-updated extension showed me we don't. How about we add a fallback but mark it as deprecated? Also there are some renderType-settings missing in core. For some unit-tests imho we don't need it and maybe we can also leave out some included in this review. Haven't re-run the functionals yet. -
Christian Kuhn voted on patch set 1 CR -1 11/05/15, 11:43
-
Morton Jonuschat commented on patch set 1 CR -1 11/05/15, 11:45
The renderType fallback should be covered by the TcaMigration: https://github.com/TYPO3/TYPO3.CMS/blob/5dee0809eac4684b1e6778eb1aabe90551eccb19/typo3/sysext/core/Classes/Migrations/TcaMigration.php#L519 -
Stefan Neufeind uploaded patch set 2 11/05/15, 11:54
-
Stefan Neufeind commented on patch set 2 11/05/15, 11:55
TcaMigration for type=select works if EXT:compatibility6 is enabled. Thanks for the hint. But we still should consider adding missing renderType-settings. -
Christian Kuhn commented on patch set 2 11/05/15, 12:14
TcaMigration works always in bootstrap. you only need compat6 loaded if you still have tca in ext_tables.php ... see the according .rst file for more information. -
Christian Kuhn commented on patch set 2 CR -1 11/05/15, 12:23
why are you adding these blindly without thinking about it and having the direct necessity?DatabaseRecordTypeValueTest.php:367not needed here.DatabaseRecordTypeValueTest.php:399not needed here.TcaInlineConfigurationTest.php:453is this needed? -
Stefan Neufeind commented on patch set 2 11/05/15, 15:49
Just for the record: The TcaMigration works clean, even without compatibility6. The problem was an extension doing crazy stuff to define TCA - which worked but passed the TcaMigration unchanged. It was the extensions fault though. Thanks Lolli for direct feedback on the TcaMigration. -
Stefan Neufeind uploaded patch set 3 11/05/15, 16:24
-
Stefan Neufeind commented on patch set 3 11/05/15, 16:25
removed the unittest-related stuff since that doesn't "render" something (but the functionals do) -
Christian Kuhn commented on patch set 3 11/05/15, 21:45
AbstractFormElement.php:386+1 -
Christian Kuhn voted on patch set 3 V +1 CR +1 11/05/15, 22:15
-
Wouter Wolters voted on patch set 3 V +2 CR +2 11/05/15, 22:40
-
Wouter Wolters merged patch set 3 11/05/15, 22:40
TcaSelectItems.php:41