Review main Merged

44553[BUGFIX] EXT:form - Remove any dependency to CSC or FSC

Ralf Zimmermann CR +2 V +2 Easy +19 −0 updated 01/09/19, 20:56

Commit message

Add the palettes "visibility" and "frames" to tt_content if they are
not available.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • Björn Jacob +1
    • Wouter Wolters +1
    • Michael Oehlhof +1
  • Verified V +2
    • Morton Jonuschat +2
    • Daniel Goerz +1
    • Josef Glatz +1
    • Björn Jacob +1
    • Wouter Wolters +1
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 18

  1. Ralf Zimmermann uploaded patch set 1 11/05/15, 13:27

  2. Björn Jacob commented on patch set 1 CR -1 V +1 11/05/15, 13:46

    Backend is okay. But we also have to tackle the FE.
  3. Björn Jacob voted on patch set 1 V 0 11/05/15, 13:46

  4. Björn Jacob commented on patch set 1 CR +1 V +1 11/05/15, 14:35

    Tested it on different installations with different methods for FE rendering. FE does work as well. BE also ready for removing CSC and/ or FSC.
  5. Andreas Kienast updated the commit message in patch set 2 11/05/15, 14:41

  6. Andreas Kienast commented on patch set 2 11/05/15, 14:42

    tt_content.php:52

    Do we need to check for isset() before?
  7. Ralf Zimmermann uploaded patch set 3 11/05/15, 14:48

  8. Björn Jacob voted on patch set 3 CR +1 V +1 11/05/15, 14:56

  9. Wouter Wolters voted on patch set 3 CR +1 11/05/15, 15:11

  10. Daniel Goerz voted on patch set 3 CR +1 V +1 11/05/15, 21:01

  11. Wouter Wolters updated the commit message in patch set 4 11/05/15, 21:09

  12. Wouter Wolters voted on patch set 4 V +1 CR +1 11/05/15, 21:10

  13. Daniel Goerz voted on patch set 4 CR +1 V +1 11/05/15, 21:10

  14. Björn Jacob commented on patch set 4 CR +1 V +1 11/06/15, 00:13

    Thx Wouter for correcting the obvious spelling error.
  15. Michael Oehlhof voted on patch set 4 CR +1 V +1 11/06/15, 08:00

  16. Morton Jonuschat voted on patch set 4 CR +2 V +2 11/06/15, 08:01

  17. Morton Jonuschat merged patch set 4 11/06/15, 08:03

  18. Josef Glatz voted on patch set 4 CR +1 V +1 01/09/19, 20:56