Review main Merged

44562[BUGFIX] Module Permissions: wrong un-/lock icon state

Josef Glatz CR +2 V +2 Easy +5 −5 updated 01/09/19, 20:56

Commit message

Fix icon state by replacing unlock with locked icon.
Add better explaining tooltip text for locked pages.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1
    • Christian Kuhn +1

Issues 1

Files 3

Review log 17

  1. Markus Klein commented on patch set 1 01/09/19, 20:56

    Question is: Does the icon represent a state or an action? Please check with the author of those lines, what the intention was.

    locallang_mod_permission.xlf:28

    Currently
  2. Michael Oehlhof voted on patch set 1 CR +1 V +1 01/09/19, 20:56

  3. Daniel Goerz commented on patch set 1 01/09/19, 20:56

    It has to be the state otherwise the tooltip (that also describe the state) needs to be changed.
  4. Daniel Goerz voted on patch set 1 CR +1 V +1 01/09/19, 20:56

  5. Daniel Goerz commented on patch set 1 01/09/19, 20:56

    Actually, I am not correct here, as the tooltip desribes the state if it is locked but the action if it is unlocked. Oh boy.
  6. Josef Glatz uploaded patch set 1 01/09/19, 20:56

  7. Josef Glatz commented on patch set 1 01/09/19, 20:56

    Thx Daniel for your info. I've also slightly adopt the tooltip for locked pages!
  8. Josef Glatz commented on patch set 1 01/09/19, 20:56

    For me as an integrator I see the column header "Lock". I assume that all pages with a locked padlock could only be edited by an adminstrator. (it's my natural feeling)
  9. Josef Glatz uploaded patch set 2 01/09/19, 20:56

  10. Markus Klein commented on patch set 3 1 comment 01/09/19, 20:56

    will update
  11. Markus Klein uploaded patch set 4 01/09/19, 20:56

  12. Markus Klein voted on patch set 4 CR +1 V +1 01/09/19, 20:56

  13. Frank Nägler voted on patch set 4 CR +2 V +2 01/09/19, 20:56

  14. Christian Kuhn voted on patch set 4 CR +1 01/09/19, 20:56

  15. Christian Kuhn voted on patch set 4 V +1 01/09/19, 20:56

  16. Frank Nägler merged patch set 4 01/09/19, 20:56

  17. Josef Glatz updated the commit message in patch set 3 01/09/19, 20:56