44562[BUGFIX] Module Permissions: wrong un-/lock icon state
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Markus Klein +1
- Christian Kuhn +1
-
Verified V +2
- Frank Nägler +2
- Markus Klein +1
- Christian Kuhn +1
Issues 1
Files 3
Review log 17
-
Markus Klein commented on patch set 1 01/09/19, 20:56
Question is: Does the icon represent a state or an action? Please check with the author of those lines, what the intention was.locallang_mod_permission.xlf:28Currently -
Michael Oehlhof voted on patch set 1 CR +1 V +1 01/09/19, 20:56
-
Daniel Goerz commented on patch set 1 01/09/19, 20:56
It has to be the state otherwise the tooltip (that also describe the state) needs to be changed. -
Daniel Goerz voted on patch set 1 CR +1 V +1 01/09/19, 20:56
-
Daniel Goerz commented on patch set 1 01/09/19, 20:56
Actually, I am not correct here, as the tooltip desribes the state if it is locked but the action if it is unlocked. Oh boy. -
Josef Glatz uploaded patch set 1 01/09/19, 20:56
-
Josef Glatz commented on patch set 1 01/09/19, 20:56
Thx Daniel for your info. I've also slightly adopt the tooltip for locked pages! -
Josef Glatz commented on patch set 1 01/09/19, 20:56
For me as an integrator I see the column header "Lock". I assume that all pages with a locked padlock could only be edited by an adminstrator. (it's my natural feeling) -
Josef Glatz uploaded patch set 2 01/09/19, 20:56
-
Markus Klein commented on patch set 3 1 comment 01/09/19, 20:56
will update -
Markus Klein uploaded patch set 4 01/09/19, 20:56
-
Markus Klein voted on patch set 4 CR +1 V +1 01/09/19, 20:56
-
Frank Nägler voted on patch set 4 CR +2 V +2 01/09/19, 20:56
-
Christian Kuhn voted on patch set 4 CR +1 01/09/19, 20:56
-
Christian Kuhn voted on patch set 4 V +1 01/09/19, 20:56
-
Frank Nägler merged patch set 4 01/09/19, 20:56
-
Josef Glatz updated the commit message in patch set 3 01/09/19, 20:56