44568[BUGFIX] Correct calculation of pageIsNotLockedForEditors
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 2
Review log 14
-
Benjamin Kott uploaded patch set 1 11/06/15, 09:38
-
Sebastian Seidelmann commented on patch set 1 11/06/15, 09:56
To reproduce: Set the rights in Access Module to readonly (binary 0001; decimal 1). Right click on page in tree view shows only the "show" action. The Topbar Buttons also show a "Edit" Button. Click on the Edit button show the exception: "Sorry, you didn't have proper permissions to perform this change. No page edit permission for user 11 on page 1 1437679336" -
Markus Klein commented on patch set 1 11/06/15, 12:19
PageLayoutController.php:1350=== please -
Markus Klein commented on patch set 1 11/06/15, 12:19
will update the patch -
Markus Klein uploaded patch set 2 11/06/15, 12:21
-
Markus Klein commented on patch set 1 11/06/15, 12:21
Reproduction instructions MUST go into the ticket please. -
Markus Klein voted on patch set 2 CR +1 V +1 11/06/15, 12:22
-
Frank Nägler voted on patch set 2 CR +1 11/06/15, 13:05
-
Christian Kuhn commented on patch set 2 CR -1 11/06/15, 13:55
unit tests for this one should be easy and would be awesome. -
Markus Klein commented on patch set 2 CR -1 11/06/15, 18:45
on it -
Markus Klein uploaded patch set 3 11/06/15, 19:47
-
Markus Klein voted on patch set 3 CR +1 V +1 11/06/15, 19:47
-
Christian Kuhn voted on patch set 3 CR +2 V +2 11/06/15, 19:52
-
Christian Kuhn merged patch set 3 11/06/15, 19:55