Review main Merged

44599[BUGFIX] Empty array not encoded as empty XML tag

Andreas Wolf CR +2 V +2 Easy +29 −5 updated 11/07/15, 15:47

Commit message

When encoding an empty array, an empty line with indentation was
created. If the <el> tag had a proper type="array" attribute, it could
still be decoded to an array again. If not, it was decoded to a string,
leading to errors e.g. when trying to traverse it.

The fix is to include an empty element now, which will be decoded to
an empty array again then.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Juan Manuel Vergés Solanas +1
    • Hans Höchtl +1
  • Verified V +2
    • Stefan Neufeind +2
    • Juan Manuel Vergés Solanas +1
    • Hans Höchtl +1

Issues 1

Files 2

Review log 12

  1. Andreas Wolf uploaded patch set 1 11/07/15, 14:11

  2. Marc Neuhaus voted on patch set 1 CR +1 V +1 11/07/15, 14:26

  3. Juan Manuel Vergés Solanas voted on patch set 1 CR +1 V +1 11/07/15, 14:35

  4. Stefan Neufeind commented on patch set 1 CR +1 11/07/15, 14:49

    testing with my local setup now
  5. Stefan Neufeind voted on patch set 1 V -1 11/07/15, 14:59

  6. Stefan Neufeind uploaded patch set 2 11/07/15, 15:00

  7. Stefan Neufeind commented on patch set 2 CR +1 V +1 11/07/15, 15:02

    Solves issues in pi_flexform with other extensions (cleans XML up now). Works great for me. Just a tiny glitch in the unit-test (phpunit => phparray).
  8. Juan Manuel Vergés Solanas voted on patch set 2 CR +1 V +1 11/07/15, 15:10

  9. Hans Höchtl voted on patch set 2 CR +1 V +1 11/07/15, 15:32

  10. Stefan Neufeind voted on patch set 2 CR +2 V +2 11/07/15, 15:33

  11. Gerrit merged patch set 2 11/07/15, 15:33

  12. Wouter Wolters commented on patch set 3 11/07/15, 15:35

    post -1

    GeneralUtility.php:2139

    empty()