Review main Merged

4460[BUGFIX] Livesearch does not find all pages

Udo Leimberger CR +2 V +2 Easy +7 −4 updated 06/03/13, 20:49

Commit message

If you are a BE user with various mount points (no admin), live search
does not find all pages.

Review

  • Code review CR +2
    • Susi Moog +2
    • Philipp Gampe +1
  • Verified V +2
    • Susi Moog +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 20

  1. Markus Klein commented on patch set 1 08/24/11, 20:01

    (2 inline comments)
    This should be: 4.5, 4.6

    class.t3lib_search_livesearch.php:120

    The variable has to be named $pageList. (CGL) Sorry this was my fault when I wrote this code in forge.
  2. Xavier Perseguers commented on patch set 1 08/24/11, 20:01

    (4 inline comments)
  3. Xavier Perseguers uploaded patch set 2 08/24/11, 20:01

  4. Markus Klein commented on patch set 3 1 comment 08/24/11, 20:01

    I would prefer that you didn't submit this Please see my comment and why does this one depend on something?
  5. Xavier Perseguers uploaded patch set 3 08/24/11, 20:01

  6. Sascha Egerer commented on patch set 4 08/24/11, 20:01

    (1 inline comment) wrong variable name
  7. Björn Pedersen commented on patch set 4 08/24/11, 20:01

    Looks good to me, but someone else must approve
  8. Susi Moog uploaded patch set 5 08/24/11, 20:01

  9. Susi Moog commented on patch set 5 08/24/11, 20:01

    Verified; Looks good to me, but someone else must approve fixed the variable naming and made the page id list unique (if you have two mounts one pointing to a subtree of the other you'll get lots of duplicates in the list).
  10. Susi Moog commented on patch set 5 V 0 08/24/11, 20:01

    by team member; Looks good to me, approved
  11. Xavier Perseguers uploaded patch set 4 08/24/11, 20:01

  12. Georg Ringer commented on patch set 1 1 comment 08/24/11, 20:01

    Looks good to me, but someone else must approve
  13. Philipp Gampe commented on patch set 1 08/24/11, 20:01

    (1 inline comment) see inline comment

    class.t3lib_search_livesearch.php:126

    Please use tabs instead of spaces for intention.
  14. Philipp Gampe commented on patch set 5 08/24/11, 20:01

    Verified; Looks good to me, but someone else must approve Works nicely.
  15. Mr. Jenkins commented on patch set 1 08/24/11, 20:01

  16. Mr. Jenkins commented on patch set 2 08/24/11, 20:01

  17. Mr. Jenkins commented on patch set 3 08/24/11, 20:01

  18. Mr. Jenkins commented on patch set 4 08/24/11, 20:01

  19. Mr. Jenkins commented on patch set 5 08/24/11, 20:01

  20. Susi Moog merged patch set 5 08/24/11, 20:01