4460[BUGFIX] Livesearch does not find all pages
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Philipp Gampe +1
-
Verified V +2
- Susi Moog +2
- Philipp Gampe +1
Issues 1
Files 1
Review log 20
-
Markus Klein commented on patch set 1 08/24/11, 20:01
(2 inline comments)This should be: 4.5, 4.6class.t3lib_search_livesearch.php:120The variable has to be named $pageList. (CGL) Sorry this was my fault when I wrote this code in forge. -
Xavier Perseguers commented on patch set 1 08/24/11, 20:01
(4 inline comments) -
Xavier Perseguers uploaded patch set 2 08/24/11, 20:01
-
Markus Klein commented on patch set 3 1 comment 08/24/11, 20:01
I would prefer that you didn't submit this Please see my comment and why does this one depend on something? -
Xavier Perseguers uploaded patch set 3 08/24/11, 20:01
-
Sascha Egerer commented on patch set 4 08/24/11, 20:01
(1 inline comment) wrong variable name -
Björn Pedersen commented on patch set 4 08/24/11, 20:01
Looks good to me, but someone else must approve -
Susi Moog uploaded patch set 5 08/24/11, 20:01
-
Susi Moog commented on patch set 5 08/24/11, 20:01
Verified; Looks good to me, but someone else must approve fixed the variable naming and made the page id list unique (if you have two mounts one pointing to a subtree of the other you'll get lots of duplicates in the list). -
Susi Moog commented on patch set 5 V 0 08/24/11, 20:01
by team member; Looks good to me, approved -
Xavier Perseguers uploaded patch set 4 08/24/11, 20:01
-
Georg Ringer commented on patch set 1 1 comment 08/24/11, 20:01
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 08/24/11, 20:01
(1 inline comment) see inline commentclass.t3lib_search_livesearch.php:126Please use tabs instead of spaces for intention. -
Philipp Gampe commented on patch set 5 08/24/11, 20:01
Verified; Looks good to me, but someone else must approve Works nicely. -
Mr. Jenkins commented on patch set 1 08/24/11, 20:01
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1692/ : SUCCESS -
Mr. Jenkins commented on patch set 2 08/24/11, 20:01
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1697/ : SUCCESS -
Mr. Jenkins commented on patch set 3 08/24/11, 20:01
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1698/ : SUCCESS -
Mr. Jenkins commented on patch set 4 08/24/11, 20:01
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1721/ : SUCCESS -
Mr. Jenkins commented on patch set 5 08/24/11, 20:01
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1725/ : SUCCESS -
Susi Moog merged patch set 5 08/24/11, 20:01