Review TYPO3_6-2 Merged

44601[BUGFIX] Empty array not encoded as empty XML tag

Stefan Neufeind CR +2 V +2 Hard +246 −479 updated 11/15/15, 11:22

Commit message

When encoding an empty array, an empty line with indentation was
created. If the <el> tag had a proper type="array" attribute, it could
still be decoded to an array again. If not, it was decoded to a string,
leading to errors e.g. when trying to traverse it.

The fix is to include an empty element now, which will be decoded to
an empty array again then.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Daniel L +1
  • Verified V +2
    • Stefan Neufeind +2
    • Daniel L +1

Issues 1

Files 21

Show 1 more file

Review log 19

  1. Stefan Neufeind uploaded patch set 1 11/07/15, 16:05

  2. Stefan Neufeind commented on patch set 1 11/07/15, 16:05

    Hand-picked. Unit-tests work for me.
  3. Andreas Wolf uploaded patch set 2 11/07/15, 17:38

  4. Andreas Wolf uploaded patch set 3 11/07/15, 21:18

  5. Stefan Froemken voted on patch set 3 CR +1 11/10/15, 20:59

  6. Michael Oehlhof voted on patch set 3 CR +1 V +1 11/12/15, 20:47

  7. Tymoteusz Motylewski voted on patch set 3 CR +1 11/14/15, 10:56

  8. Andreas Kienast commented on patch set 3 CR -1 V -1 11/14/15, 14:59

    Patch is not applicable on current master due to PSR-2 changes.
  9. Stefan Neufeind commented on patch set 3 11/14/15, 16:17

    note that this one is for 6.2 and master is merged already. anything special (whitespaces, ...) that you stumbled across that needs to become non-PSR-2 for 6.2 here?
  10. Stefan Neufeind commented on patch set 3 CR -1 11/14/15, 16:20

    GeneralUtilityTest.php:4686

    must be array() because short-array-syntax is php 5.4 and TYPO3 6.2 is 5.3
  11. Stefan Neufeind commented on patch set 3 11/14/15, 16:22

    I'll push an update in a minute because of the short-array-syntax ...
  12. Stefan Neufeind uploaded patch set 4 11/14/15, 16:27

  13. Stefan Neufeind commented on patch set 4 V +1 11/14/15, 16:28

    tests run fine (but I only had php 5.6 available ...)
  14. Andreas Kienast commented on patch set 4 11/14/15, 16:34

    Ah sorry, I didn't notice the TYPO3_6-2 branch.
  15. Stefan Neufeind commented on patch set 4 CR +1 11/14/15, 17:44

    functionals also work fine for me
  16. Daniel L voted on patch set 4 CR +1 11/14/15, 19:45

  17. Daniel L commented on patch set 4 V +1 11/15/15, 10:57

    Works for me, too.
  18. Stefan Neufeind voted on patch set 4 CR +2 V +2 11/15/15, 11:22

  19. Gerrit merged patch set 4 11/15/15, 11:22