44601[BUGFIX] Empty array not encoded as empty XML tag
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Daniel L +1
-
Verified V +2
- Stefan Neufeind +2
- Daniel L +1
Issues 1
Files 21
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+9 −5
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php1binary
- typo3/sysext/impexp/Tests/Functional/Fixtures/ImportExportXml/impexp-group-file-and-file_reference-item-in-ff.xml+10 −20
- typo3/sysext/impexp/Tests/Functional/Fixtures/ImportExportXml/impexp-group-file-and-file_reference-item.xml+10 −20
- typo3/sysext/impexp/Tests/Functional/Fixtures/ImportExportXml/irre-records.xml+71 −142
- typo3/sysext/impexp/Tests/Functional/Fixtures/ImportExportXml/pages-and-ttcontent-with-image.xml+18 −36
- typo3/sysext/impexp/Tests/Functional/Fixtures/ImportExportXml/pages-and-ttcontent-with-rte-image-n-file-link.xml+14 −28
- typo3/sysext/impexp/Tests/Functional/Fixtures/ImportExportXml/pages-and-ttcontent.xml+12 −24
- typo3/sysext/impexp/Tests/Functional/Import/GroupFileAndFileReferenceItem/ImportExportXml/impexp-group-file-and-file_reference-item-on-pid-zero.xml+7 −14
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImages/ImportExportXml/pages-and-ttcontent-with-existing-different-image.xml+12 −24
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImages/ImportExportXml/pages-and-ttcontent-with-existing-same-image.xml+12 −24
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImages/ImportExportXml/pages-and-ttcontent-with-image-with-forced-uids.xml+11 −22
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImages/ImportExportXml/pages-and-ttcontent-with-image-with-spaces-in-path.xml+12 −24
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImages/ImportExportXml/pages-and-ttcontent-with-image-without-storage.xml+14 −28
- typo3/sysext/impexp/Tests/Functional/ImportFromVersionFourDotFive/GroupFileAndFileReferenceItem/ImportExportXml/impexp-group-file-and-file_reference-item.xml+5 −10
- typo3/sysext/impexp/Tests/Functional/ImportFromVersionFourDotFive/GroupFileAndFileReferenceItemInFlexForm/ImportExportXml/impexp-group-file-and-file_reference-item-in-ff.xml+4 −8
- typo3/sysext/impexp/Tests/Functional/ImportFromVersionFourDotFive/PagesAndTtContent/ImportExportXml/pages-and-ttcontent.xml+5 −10
- typo3/sysext/impexp/Tests/Functional/ImportFromVersionFourDotFive/PagesAndTtContentUploads/ImportExportXml/pages-and-ttcontent-uploads.xml+5 −10
- typo3/sysext/impexp/Tests/Functional/ImportFromVersionFourDotFive/PagesAndTtContentWithImages/ImportExportXml/pages-and-ttcontent-with-images.xml+4 −8
- typo3/sysext/impexp/Tests/Functional/ImportFromVersionFourDotFive/PagesAndTtContentWithRteImagesAndFileLink/ImportExportXml/pages-and-ttcontent-with-rte-image-n-file-link.xml+4 −8
Review log 19
-
Stefan Neufeind uploaded patch set 1 11/07/15, 16:05
-
Stefan Neufeind commented on patch set 1 11/07/15, 16:05
Hand-picked. Unit-tests work for me. -
Andreas Wolf uploaded patch set 2 11/07/15, 17:38
-
Andreas Wolf uploaded patch set 3 11/07/15, 21:18
-
Stefan Froemken voted on patch set 3 CR +1 11/10/15, 20:59
-
Michael Oehlhof voted on patch set 3 CR +1 V +1 11/12/15, 20:47
-
Tymoteusz Motylewski voted on patch set 3 CR +1 11/14/15, 10:56
-
Andreas Kienast commented on patch set 3 CR -1 V -1 11/14/15, 14:59
Patch is not applicable on current master due to PSR-2 changes. -
Stefan Neufeind commented on patch set 3 11/14/15, 16:17
note that this one is for 6.2 and master is merged already. anything special (whitespaces, ...) that you stumbled across that needs to become non-PSR-2 for 6.2 here? -
Stefan Neufeind commented on patch set 3 CR -1 11/14/15, 16:20
GeneralUtilityTest.php:4686must be array() because short-array-syntax is php 5.4 and TYPO3 6.2 is 5.3 -
Stefan Neufeind commented on patch set 3 11/14/15, 16:22
I'll push an update in a minute because of the short-array-syntax ... -
Stefan Neufeind uploaded patch set 4 11/14/15, 16:27
-
Stefan Neufeind commented on patch set 4 V +1 11/14/15, 16:28
tests run fine (but I only had php 5.6 available ...) -
Andreas Kienast commented on patch set 4 11/14/15, 16:34
Ah sorry, I didn't notice the TYPO3_6-2 branch. -
Stefan Neufeind commented on patch set 4 CR +1 11/14/15, 17:44
functionals also work fine for me -
Daniel L voted on patch set 4 CR +1 11/14/15, 19:45
-
Daniel L commented on patch set 4 V +1 11/15/15, 10:57
Works for me, too. -
Stefan Neufeind voted on patch set 4 CR +2 V +2 11/15/15, 11:22
-
Gerrit merged patch set 4 11/15/15, 11:22