Review main Merged

4461[TASK] Use autoloader in rsaauth system extension

Helmut Hummel CR +2 V +2 Easy +21 −14 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Susi Moog +2
    • Christian Kuhn +1
    • Xavier Perseguers +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1

Issues 1

Files 12

Review log 10

  1. Susi Moog commented on patch set 2 V 0 08/22/11, 12:45

    by team member; Looks good to me, approved
  2. Xavier Perseguers commented on patch set 2 08/22/11, 12:45

    Looks good to me, but someone else must approve
  3. Helmut Hummel uploaded patch set 2 08/22/11, 12:45

  4. Helmut Hummel commented on patch set 2 08/22/11, 12:45

    Sorry, resubmitted, because it is a dependency to another task. don't know how to avoid this.
  5. Christian Kuhn commented on patch set 2 08/22/11, 12:45

    Verified; Looks good to me, but someone else must approve +1 Hint: Since this patch changes the needed classes used for login / bootstrap, the autoloader cache has to be deleted manually on dev systems (will not happen to users upgrading TYPO3). More info at http://wiki.typo3.org/Caching_framework#Used_core_caches
  6. Georg Ringer commented on patch set 2 08/22/11, 12:45

    Looks good to me, approved
  7. Philipp Gampe commented on patch set 1 08/22/11, 12:45

    Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 08/22/11, 12:45

  9. Mr. Jenkins commented on patch set 2 08/22/11, 12:45

  10. Susi Moog merged patch set 2 08/22/11, 12:45