4461[TASK] Use autoloader in rsaauth system extension
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Susi Moog +2
- Christian Kuhn +1
- Xavier Perseguers +1
-
Verified V +2
- Susi Moog +2
- Christian Kuhn +1
Issues 1
Files 12
- typo3/sysext/rsaauth/hooks/class.tx_rsaauth_backendwarnings.php+0 −1
- typo3/sysext/rsaauth/hooks/class.tx_rsaauth_feloginhook.php+0 −2
- typo3/sysext/rsaauth/hooks/class.tx_rsaauth_loginformhook.php+0 −2
- typo3/sysext/rsaauth/sv1/backends/class.tx_rsaauth_abstract_backend.php+0 −1
- typo3/sysext/rsaauth/sv1/backends/class.tx_rsaauth_backendfactory.php+0 −1
- typo3/sysext/rsaauth/sv1/backends/class.tx_rsaauth_cmdline_backend.php+0 −1
- typo3/sysext/rsaauth/sv1/backends/class.tx_rsaauth_php_backend.php+0 −1
- typo3/sysext/rsaauth/sv1/storage/class.tx_rsaauth_session_storage.php+0 −1
- typo3/sysext/rsaauth/sv1/storage/class.tx_rsaauth_split_storage.php+0 −1
- typo3/sysext/rsaauth/sv1/storage/class.tx_rsaauth_storagefactory.php+0 −1
- typo3/sysext/rsaauth/sv1/class.tx_rsaauth_sv1.php+0 −2
- typo3/sysext/rsaauth/ext_autoload.phpnew+21 −0
Review log 10
-
Susi Moog commented on patch set 2 V 0 08/22/11, 12:45
by team member; Looks good to me, approved -
Xavier Perseguers commented on patch set 2 08/22/11, 12:45
Looks good to me, but someone else must approve -
Helmut Hummel uploaded patch set 2 08/22/11, 12:45
-
Helmut Hummel commented on patch set 2 08/22/11, 12:45
Sorry, resubmitted, because it is a dependency to another task. don't know how to avoid this. -
Christian Kuhn commented on patch set 2 08/22/11, 12:45
Verified; Looks good to me, but someone else must approve +1 Hint: Since this patch changes the needed classes used for login / bootstrap, the autoloader cache has to be deleted manually on dev systems (will not happen to users upgrading TYPO3). More info at http://wiki.typo3.org/Caching_framework#Used_core_caches -
Georg Ringer commented on patch set 2 08/22/11, 12:45
Looks good to me, approved -
Philipp Gampe commented on patch set 1 08/22/11, 12:45
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 08/22/11, 12:45
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1693/ : SUCCESS -
Mr. Jenkins commented on patch set 2 08/22/11, 12:45
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1695/ : SUCCESS -
Susi Moog merged patch set 2 08/22/11, 12:45