44617[BUGFIX] Update tstamp on writeForeignField if any foreign value has changed. (IRRE)
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Markus Sommer +1
- Oliver Eglseder +1
-
Verified V +2
- Jigal van Hemert +2
- Markus Sommer +1
- Oliver Eglseder +1
Issues 1
Files 1
Review log 17
-
Sebastian Mazza uploaded patch set 1 11/08/15, 19:47
-
Andreas Kienast commented on patch set 2 11/09/15, 16:58
Published edit on patch set 1 -
Andreas Kienast commented on patch set 3 11/09/15, 17:00
Published edit on patch set 2 -
Michael Oehlhof voted on patch set 3 CR +1 V +1 11/14/15, 13:17
-
Oliver Eglseder commented on patch set 3 CR -1 11/14/15, 16:35
RelationHandler.php:935Please check with !empty() or this would produce an E_NOTICE when the key is not set -
Sebastian Mazza uploaded patch set 4 11/15/15, 02:26
-
Oliver Eglseder voted on patch set 4 CR +1 V +1 11/15/15, 11:11
-
Jigal van Hemert voted on patch set 4 CR +1 V +1 11/15/15, 14:59
-
Markus Sommer voted on patch set 4 CR +1 V +1 11/15/15, 18:58
-
Frank Nägler commented on patch set 4 11/16/15, 15:05
RelationHandler.php:939why update is needed in case we get no record? -
Sebastian Mazza commented on patch set 4 11/16/15, 15:47
@Frank Nägler: I have written that to ensure that the tstamp is correct. Just to make sure. But this shouldn't take any effect because the exec_UPDATEquery() will fail anyway if the recod isn't in the DB. -
Frank Nägler commented on patch set 4 11/16/15, 16:58
So, if this check is useless, then you can check: if (!empty($currentRow)) { for.... } no else needed and to "useless" update query. Code is then a little bit cleaner -
Daniel L commented on patch set 4 11/16/15, 18:57
@Frank Nägler: Should we give -1 for Code-Review to clean up this condition? -
Sebastian Mazza commented on patch set 4 11/16/15, 19:39
I can not imagine a case where the $currentRow is empty and the update doe’s not fail. But if such a case exists it would be better to update the tstamp even if it is not necessary then to change something on the record without updating the tstamp. -
Frank Nägler commented on patch set 4 11/20/15, 10:41
Sorry for the late response, was a little bit busy the last days. So I don't understand why the update is needed, but I don't will block this patch. If Jigal is fine with the patch, he can merge it. This patch has enough votes, fine for me too. -
Jigal van Hemert voted on patch set 4 CR +2 V +2 11/23/15, 15:02
-
Gerrit merged patch set 4 11/23/15, 15:02