4462[TASK] Encrypt password transmission in user setup
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Xavier Perseguers +2
-
Verified V +2
- Georg Ringer +2
- Xavier Perseguers +2
Issues 1
Files 5
Review log 13
-
Helmut Hummel commented on patch set 2 09/07/11, 20:07
Thanks Georg for the comments. I will fix this once the autoloader patch is commited... -
Helmut Hummel uploaded patch set 2 09/07/11, 20:07
-
Helmut Hummel commented on patch set 2 09/07/11, 20:07
(4 inline comments) -
Helmut Hummel commented on patch set 2 09/07/11, 20:07
Fixed copyright header in patch set 2 -
Xavier Perseguers commented on patch set 3 09/07/11, 20:07
Looks good to me, but someone else must approve To start with... -
Xavier Perseguers commented on patch set 3 V 0 09/07/11, 20:07
by team member; Looks good to me, approved -
Helmut Hummel uploaded patch set 3 09/07/11, 20:07
-
Georg Ringer commented on patch set 2 09/07/11, 20:07
Looks good to me, but someone else must approveclass.tx_rsaauth_usersetuphook.php:42add type hintingclass.tx_rsaauth_usersetuphook.php:71can we use typehinting for pObj too?class.tx_rsaauth_usersetuphook.php:74+ 1 tab, also for other comments in this fileindex.php:318imo it should be $javaScript -
Georg Ringer commented on patch set 3 V 0 09/07/11, 20:07
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 09/07/11, 20:07
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1694/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/07/11, 20:07
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1696/ : SUCCESS -
Mr. Jenkins commented on patch set 3 09/07/11, 20:07
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1712/ : SUCCESS -
Helmut Hummel merged patch set 3 09/07/11, 20:07