Review main Merged

4462[TASK] Encrypt password transmission in user setup

Helmut Hummel CR +2 V +2 Normal +179 −12 updated 06/03/13, 20:49

Commit message

If extension rsaauth is enabled, the password transmission
when saving the user settings form should be encrypted.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Xavier Perseguers +2
  • Verified V +2
    • Georg Ringer +2
    • Xavier Perseguers +2

Issues 1

Files 5

Review log 13

  1. Helmut Hummel commented on patch set 2 09/07/11, 20:07

    Thanks Georg for the comments. I will fix this once the autoloader patch is commited...
  2. Helmut Hummel uploaded patch set 2 09/07/11, 20:07

  3. Helmut Hummel commented on patch set 2 09/07/11, 20:07

    (4 inline comments)
  4. Helmut Hummel commented on patch set 2 09/07/11, 20:07

    Fixed copyright header in patch set 2
  5. Xavier Perseguers commented on patch set 3 09/07/11, 20:07

    Looks good to me, but someone else must approve To start with...
  6. Xavier Perseguers commented on patch set 3 V 0 09/07/11, 20:07

    by team member; Looks good to me, approved
  7. Helmut Hummel uploaded patch set 3 09/07/11, 20:07

  8. Georg Ringer commented on patch set 2 09/07/11, 20:07

    Looks good to me, but someone else must approve

    class.tx_rsaauth_usersetuphook.php:42

    add type hinting

    class.tx_rsaauth_usersetuphook.php:71

    can we use typehinting for pObj too?

    class.tx_rsaauth_usersetuphook.php:74

    + 1 tab, also for other comments in this file

    index.php:318

    imo it should be $javaScript
  9. Georg Ringer commented on patch set 3 V 0 09/07/11, 20:07

    by team member; Looks good to me, approved
  10. Mr. Jenkins commented on patch set 1 09/07/11, 20:07

  11. Mr. Jenkins commented on patch set 2 09/07/11, 20:07

  12. Mr. Jenkins commented on patch set 3 09/07/11, 20:07

  13. Helmut Hummel merged patch set 3 09/07/11, 20:07