Review main Merged

44620[BUGFIX] Bring declarations of wrapTitle() in line

Markus Klein CR +2 V +2 Easy +3 −2 updated 11/09/15, 08:20

Commit message

The declaration of ElementBrowserFolderTreeView::wrapTitle() must match
its parent function's declaration, otherwise PHP7 will issue a warning.

Review

  • Code review CR +2
    • Benni Mack +2
    • Michael Oehlhof +1
  • Verified V +2
    • Benni Mack +2
    • Michael Oehlhof +1

Issues 1

Files 1

Review log 5

  1. Markus Klein uploaded patch set 1 11/08/15, 22:55

  2. Markus Klein commented on patch set 2 11/08/15, 22:56

    Published edit on patch set 1
  3. Michael Oehlhof voted on patch set 2 CR +1 V +1 11/09/15, 06:06

  4. Benni Mack voted on patch set 2 CR +2 V +2 11/09/15, 08:20

  5. Gerrit merged patch set 2 11/09/15, 08:20