44626[TASK] Hide "upload extension" button in composer mode
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Helmut Hummel +1
-
Verified V +2
- Markus Klein +2
- Helmut Hummel +1
Issues 1
Files 2
Review log 14
-
Daniel Goerz uploaded patch set 1 11/09/15, 09:44
-
Andreas Kienast voted on patch set 1 CR +1 11/09/15, 09:53
-
Michael Oehlhof voted on patch set 1 CR +1 V +1 11/09/15, 09:55
-
Helmut Hummel commented on patch set 1 CR -1 11/09/15, 10:16
seems to be introduced after the module template change. Can't judge though. I'd like to have Nicole have a look -
Daniel Goerz commented on patch set 1 11/09/15, 14:53
Yes, this was introduced by https://review.typo3.org/44403 and composer mode was just forgotton. Sice there are no buttons in the one view available in composer mode, we simply can early return here. -
Nicole Hummel commented on patch set 1 CR -1 11/09/15, 16:18
On it -
Nicole Hummel uploaded patch set 2 11/09/15, 16:26
-
Nicole Hummel voted on patch set 2 CR +2 V +2 11/09/15, 16:26
-
Andreas Kienast voted on patch set 2 CR +1 11/09/15, 16:56
-
Helmut Hummel commented on patch set 2 CR -2 11/09/15, 16:58
I'm reviewing it now -
Helmut Hummel uploaded patch set 3 11/09/15, 17:22
-
Helmut Hummel voted on patch set 3 CR +1 V +1 11/09/15, 17:23
-
Markus Klein voted on patch set 3 CR +2 V +2 11/09/15, 19:31
-
Gerrit merged patch set 3 11/09/15, 19:31