44627[BUGFIX] Respect allowed_languages for restricted backend users
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Andreas Allacher +1
- Mathias Schreiber +1
-
Verified V +2
- Helmut Hummel +2
- Andreas Allacher +1
- Mathias Schreiber +1
Issues 1
Files 1
Review log 22
-
Andreas Kienast uploaded patch set 1 11/09/15, 09:52
-
Andreas Kienast uploaded patch set 2 11/09/15, 09:52
-
Markus Klein commented on patch set 2 CR +1 11/09/15, 10:54
Makes sense -
Andreas Allacher commented on patch set 2 11/09/15, 15:05
LocalizationController.php:106Is there a reason why this check isn't done directly in the query if non admin user? -
Mathias Schreiber voted on patch set 2 CR +1 V +1 11/09/15, 15:06
-
Andreas Kienast commented on patch set 2 11/09/15, 15:13
LocalizationController.php:106ReplyErm, look! A three-headed monkey. Will push an update :) -
Andreas Kienast uploaded patch set 3 11/09/15, 15:15
-
Andreas Kienast voted on patch set 3 CR -1 11/09/15, 15:17
-
Andreas Kienast uploaded patch set 4 11/09/15, 15:20
-
Andreas Kienast uploaded patch set 5 11/09/15, 15:36
-
Andreas Allacher voted on patch set 5 CR +1 11/09/15, 15:38
-
Mathias Schreiber voted on patch set 5 CR +1 V +1 11/09/15, 15:55
-
Andreas Allacher commented on patch set 5 V +1 11/09/15, 15:58
Seems to work too, language selector tested -
Helmut Hummel commented on patch set 5 11/09/15, 16:00
LocalizationController.php:88intval here pleaseLocalizationController.php:89and hereLocalizationController.php:90and hereLocalizationController.php:106what is this for? if it is just for the lookup, please put the cast there or use an additional local variable -
Helmut Hummel commented on patch set 5 CR -2 11/09/15, 16:02
I'll push a new patchset -
Andreas Allacher commented on patch set 5 11/09/15, 16:02
LocalizationController.php:90ReplySee definition of pageId etc. above -
Andreas Kienast commented on patch set 5 11/09/15, 16:08
LocalizationController.php:88ReplyAlready done a few lines above.LocalizationController.php:106ReplyProbably not required anymore -
Helmut Hummel commented on patch set 5 11/09/15, 16:22
LocalizationController.php:106Replyprobably? is it required or not. There is only one possiblity ;) -
Helmut Hummel voted on patch set 5 CR 0 11/09/15, 16:22
-
Helmut Hummel commented on patch set 5 11/09/15, 16:22
I will do an additional patch to fix the queries -
Helmut Hummel voted on patch set 5 CR +2 V +2 11/09/15, 16:39
-
Gerrit merged patch set 5 11/09/15, 16:39