Review main Merged

44627[BUGFIX] Respect allowed_languages for restricted backend users

Andreas Kienast CR +2 V +2 Easy +12 −1 updated 11/09/15, 16:39

Commit message

Fix the broken SQL query and remove disallowed system languages for
restricted backend users.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Andreas Allacher +1
    • Mathias Schreiber +1
  • Verified V +2
    • Helmut Hummel +2
    • Andreas Allacher +1
    • Mathias Schreiber +1

Issues 1

Files 1

Review log 22

  1. Andreas Kienast uploaded patch set 1 11/09/15, 09:52

  2. Andreas Kienast uploaded patch set 2 11/09/15, 09:52

  3. Markus Klein commented on patch set 2 CR +1 11/09/15, 10:54

    Makes sense
  4. Andreas Allacher commented on patch set 2 11/09/15, 15:05

    LocalizationController.php:106

    Is there a reason why this check isn't done directly in the query if non admin user?
  5. Mathias Schreiber voted on patch set 2 CR +1 V +1 11/09/15, 15:06

  6. Andreas Kienast commented on patch set 2 11/09/15, 15:13

    LocalizationController.php:106 Reply

    Erm, look! A three-headed monkey. Will push an update :)
  7. Andreas Kienast uploaded patch set 3 11/09/15, 15:15

  8. Andreas Kienast voted on patch set 3 CR -1 11/09/15, 15:17

  9. Andreas Kienast uploaded patch set 4 11/09/15, 15:20

  10. Andreas Kienast uploaded patch set 5 11/09/15, 15:36

  11. Andreas Allacher voted on patch set 5 CR +1 11/09/15, 15:38

  12. Mathias Schreiber voted on patch set 5 CR +1 V +1 11/09/15, 15:55

  13. Andreas Allacher commented on patch set 5 V +1 11/09/15, 15:58

    Seems to work too, language selector tested
  14. Helmut Hummel commented on patch set 5 11/09/15, 16:00

    LocalizationController.php:88

    intval here please

    LocalizationController.php:89

    and here

    LocalizationController.php:90

    and here

    LocalizationController.php:106

    what is this for? if it is just for the lookup, please put the cast there or use an additional local variable
  15. Helmut Hummel commented on patch set 5 CR -2 11/09/15, 16:02

    I'll push a new patchset
  16. Andreas Allacher commented on patch set 5 11/09/15, 16:02

    LocalizationController.php:90 Reply

    See definition of pageId etc. above
  17. Andreas Kienast commented on patch set 5 11/09/15, 16:08

    LocalizationController.php:88 Reply

    Already done a few lines above.

    LocalizationController.php:106 Reply

    Probably not required anymore
  18. Helmut Hummel commented on patch set 5 11/09/15, 16:22

    LocalizationController.php:106 Reply

    probably? is it required or not. There is only one possiblity ;)
  19. Helmut Hummel voted on patch set 5 CR 0 11/09/15, 16:22

  20. Helmut Hummel commented on patch set 5 11/09/15, 16:22

    I will do an additional patch to fix the queries
  21. Helmut Hummel voted on patch set 5 CR +2 V +2 11/09/15, 16:39

  22. Gerrit merged patch set 5 11/09/15, 16:39