Review main Merged

44646[TASK] Simplify missing link browser JS implementation detection

Markus Klein CR +2 V +2 Easy +20 −22 updated 11/10/15, 06:26

Commit message

Instead of letting each handler check if the finalize function of the
LinkBrowser is implemented, assign a default function, which will throw
the exception.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stephan Großberndt +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1

Issues 1

Files 5

Review log 6

  1. Markus Klein uploaded patch set 1 11/09/15, 18:12

  2. Stephan Großberndt commented on patch set 2 11/09/15, 18:24

    Published edit on patch set 1
  3. Stephan Großberndt voted on patch set 2 CR +1 11/09/15, 18:25

  4. Wouter Wolters voted on patch set 2 CR +1 V +1 11/09/15, 19:34

  5. Benni Mack voted on patch set 2 CR +2 V +2 11/10/15, 06:26

  6. Gerrit merged patch set 2 11/10/15, 06:26