Review main Merged

44682[BUGFIX] Close extension configuration form on "Save and close"

Andreas Kienast CR +2 V +2 Easy +13 −3 updated 11/11/15, 12:23

Commit message

Add the input field for the final action override in a pre-submit callback
to close the configuration form if a user clicks "Save and close".

Review

  • Code review CR +2
    • Mathias Schreiber +2
    • Daniel Goerz +1
    • Eric Chavaillaz +1
  • Verified V +2
    • Mathias Schreiber +2
    • Daniel Goerz +1
    • Eric Chavaillaz +1

Issues 1

Files 1

Review log 6

  1. Andreas Kienast uploaded patch set 1 11/11/15, 12:15

  2. Daniel Goerz voted on patch set 1 CR +1 V +1 11/11/15, 12:18

  3. Eric Chavaillaz voted on patch set 1 CR +1 V +1 11/11/15, 12:19

  4. Mathias Schreiber voted on patch set 1 CR +2 V +2 11/11/15, 12:22

  5. Gerrit merged patch set 1 11/11/15, 12:22

  6. Wouter Wolters commented on patch set 2 11/11/15, 12:23

    post +1