Review main Merged

44701[BUGFIX] Remove HTML markup from flashMessage

Frank Nägler CR +2 V +2 Easy +13 −7 updated 11/15/15, 14:49

Commit message

This patch adds the possibility to add line breaks to JS Notifications
to be able to structure the output of extension installation messages.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Richard Haeser +1
  • Verified V +2
    • Jigal van Hemert +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Richard Haeser +1

Issues 1

Files 4

Review log 16

  1. Frank Nägler uploaded patch set 1 11/13/15, 09:55

  2. Wouter Wolters voted on patch set 1 CR +1 V +1 11/13/15, 11:40

  3. Richard Haeser voted on patch set 1 CR +1 11/13/15, 11:46

  4. Nicole Hummel commented on patch set 1 CR -1 11/13/15, 12:16

    On it
  5. Nicole Hummel uploaded patch set 2 11/13/15, 12:57

  6. Mathias Schreiber commented on patch set 2 11/13/15, 13:11

    Notification.js:177

    can we do this via a real class? Maybe even bind it to .alert .media-body .alert-message?
  7. Nicole Hummel commented on patch set 2 11/13/15, 13:47

    Notification.js:177 Reply

    I can't ^^
  8. Frank Nägler commented on patch set 2 11/13/15, 15:08

    Notification.js:177 Reply

    yes, no inline styles please... Why we need inline css here? don't get it.
  9. Markus Sommer commented on patch set 2 CR -1 V +1 11/13/15, 21:30

    Why we need this inline? "style="white-space: pre-wrap;"
  10. Nicole Hummel commented on patch set 2 11/14/15, 00:53

    Notification.js:177 Reply

    I never said, that we need the inline style. I need the CSS to permit line breaks in the message text. I can't do any less because I don't have the environment. So if you need a class here, feel free to push a new patch. Nevermind there is still some more places with inline style in core.
  11. Harry Glatz uploaded patch set 3 11/14/15, 18:36

  12. Josef Glatz voted on patch set 3 CR +1 V +1 11/14/15, 18:43

  13. Georg Ringer voted on patch set 3 CR +1 V +1 11/14/15, 20:02

  14. Richard Haeser voted on patch set 3 CR +1 V +1 11/15/15, 14:39

  15. Jigal van Hemert voted on patch set 3 CR +2 V +2 11/15/15, 14:49

  16. Gerrit merged patch set 3 11/15/15, 14:49