44701[BUGFIX] Remove HTML markup from flashMessage
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Josef Glatz +1
- Georg Ringer +1
- Richard Haeser +1
-
Verified V +2
- Jigal van Hemert +2
- Josef Glatz +1
- Georg Ringer +1
- Richard Haeser +1
Issues 1
Files 4
Review log 16
-
Frank Nägler uploaded patch set 1 11/13/15, 09:55
-
Wouter Wolters voted on patch set 1 CR +1 V +1 11/13/15, 11:40
-
Richard Haeser voted on patch set 1 CR +1 11/13/15, 11:46
-
Nicole Hummel commented on patch set 1 CR -1 11/13/15, 12:16
On it -
Nicole Hummel uploaded patch set 2 11/13/15, 12:57
-
Mathias Schreiber commented on patch set 2 11/13/15, 13:11
Notification.js:177can we do this via a real class? Maybe even bind it to .alert .media-body .alert-message? -
Nicole Hummel commented on patch set 2 11/13/15, 13:47
Notification.js:177ReplyI can't ^^ -
Frank Nägler commented on patch set 2 11/13/15, 15:08
Notification.js:177Replyyes, no inline styles please... Why we need inline css here? don't get it. -
Markus Sommer commented on patch set 2 CR -1 V +1 11/13/15, 21:30
Why we need this inline? "style="white-space: pre-wrap;" -
Nicole Hummel commented on patch set 2 11/14/15, 00:53
Notification.js:177ReplyI never said, that we need the inline style. I need the CSS to permit line breaks in the message text. I can't do any less because I don't have the environment. So if you need a class here, feel free to push a new patch. Nevermind there is still some more places with inline style in core. -
Harry Glatz uploaded patch set 3 11/14/15, 18:36
-
Josef Glatz voted on patch set 3 CR +1 V +1 11/14/15, 18:43
-
Georg Ringer voted on patch set 3 CR +1 V +1 11/14/15, 20:02
-
Richard Haeser voted on patch set 3 CR +1 V +1 11/15/15, 14:39
-
Jigal van Hemert voted on patch set 3 CR +2 V +2 11/15/15, 14:49
-
Gerrit merged patch set 3 11/15/15, 14:49