Review main Merged

44704[BUGFIX] EXT:form - Fix utf-8 encoding for error message

Stano Paska CR +2 V +2 Easy +1 −1 updated 11/13/15, 19:29

Commit message

This patchset fixes a problem with the error message. As soon as the
message contains utf-8 characters, they are not properly displayed.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Björn Jacob +1
    • Morton Jonuschat +1
  • Verified V +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Björn Jacob +1
    • Morton Jonuschat +1

Issues 1

Files 1

Review log 7

  1. Stano Paska uploaded patch set 1 11/13/15, 13:12

  2. Björn Jacob commented on patch set 2 11/13/15, 13:22

    Published edit on patch set 1
  3. Morton Jonuschat voted on patch set 2 CR +1 V +1 11/13/15, 16:24

  4. Björn Jacob commented on patch set 2 CR +1 V +1 11/13/15, 19:16

    See example form. That way it's reproducable. Tested also with plugin.tx_form.settings.registeredElements.FORM.compatibilityMode = 0. There we're not having a problem.
  5. Daniel Goerz voted on patch set 2 CR +1 V +1 11/13/15, 19:21

  6. Georg Ringer voted on patch set 2 CR +2 V +2 11/13/15, 19:29

  7. Gerrit merged patch set 2 11/13/15, 19:29