Review main Merged

44707[BUGFIX] Wrong overloading of AbstractController::redirect()

Frank Nägler CR +2 V +2 Easy +3 −1 updated 12/08/15, 18:19

Commit message

This patch add a todo for deprecation in CMS8 and remove the usage
of the wrong overloaded method in the core.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Markus Sommer +1
    • Oliver Eglseder +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Markus Sommer +1
    • Oliver Eglseder +1

Issues 1

Files 1

Review log 10

  1. Frank Nägler uploaded patch set 1 11/13/15, 15:46

  2. Mathias Brodala commented on patch set 1 11/13/15, 15:53

    BackendModuleController.php:62

    Why not AbstractController::redirectToUri()?
  3. Markus Sommer voted on patch set 1 CR +1 V +1 11/13/15, 20:07

  4. Oliver Eglseder commented on patch set 1 CR +1 V +1 11/13/15, 20:47

    BackendModuleController.php:62 Reply

    This would change the functionality, because redirectToUri does way more stuff like clearing caches etc.
  5. Tymoteusz Motylewski voted on patch set 1 CR +1 V +1 11/14/15, 10:26

  6. Tymoteusz Motylewski voted on patch set 1 CR +2 V +2 11/14/15, 10:39

  7. Gerrit merged patch set 1 11/14/15, 10:39

  8. Torben Hansen commented on patch set 2 12/07/15, 18:24

    I applied the patch manually to a TYPO3 7.6.0 installation and still get the error described in #71303 using PHP 7.0. It first disappears when I remove the redirect function or adapt it to the declaration required by AbstractController::redirect
  9. Frank Nägler commented on patch set 2 12/07/15, 18:42

    @Torben: The method is deprecated know and will be removed in CMS8, we can't remove it yet or change the signature without an breaking change.
  10. Torben Hansen commented on patch set 2 12/08/15, 18:19

    @Frank: But how can I avoid the PHP strict warning from appearing? No matter what I set in TYPO3 install tool (Production/Development), I always get the PHP warning with "xxx should be compatible with yyy". Is it suggested to completely disable PHP error reporting using PHP 7?