44713[BUGFIX] Do not prepend siteUrl in RTE when handler keyword is present
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Markus Sommer +1
- Oliver Eglseder +1
-
Verified V +2
- Jigal van Hemert +2
- Markus Sommer +1
Issues 1
Files 1
Review log 9
-
Markus Klein uploaded patch set 1 11/13/15, 21:02
-
Markus Klein commented on patch set 2 11/13/15, 21:11
Published edit on patch set 1 -
Markus Sommer voted on patch set 2 CR +1 V +1 11/13/15, 21:12
-
Oliver Eglseder voted on patch set 2 CR +1 11/13/15, 21:17
-
Tymoteusz Motylewski commented on patch set 2 11/14/15, 10:45
Hi Do you have some code example/test extension to ease testing? -
Philipp Wrann commented on patch set 2 11/14/15, 12:00
It would work that way i think - i am pretty sure and will have a look at it on monday. But in general i would say that is only a hotfix, it should probably be fixed serverside, there you know about all registered keywords and can do that much better (when transforming the value for database). All keywords are present in: $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['typolinkLinkHandler'] To make usage of the api more transparent for developers the keywords "file" and "mailto" could be registered that way instead of having those hardcoded. or even better - add the link transformation to the LinkHandlerInterface. -
Markus Klein commented on patch set 2 11/14/15, 12:37
@wrann: For sure it would be nice to do this on server side, but it is simply not possible. All the links must be transformed to a valid link (either FormEngine or RTE) in JS to be handed over to the calling code correctly already. I could pass the known handler keywords into JS already, but there are some edge cases, which I do not dare to touch. Generally I'd like to streamline this API even more, but then we need an upgrade wizard for all the RTE content, to migrate it to the new format. This is more a topic for CMS 8 and since we aim for a RTE replacement anyway, I'll not invest too much time into this linking details in RTE anymore. -
Jigal van Hemert voted on patch set 2 CR +2 V +2 11/15/15, 15:08
-
Gerrit merged patch set 2 11/15/15, 15:08