Review main Merged

44717[BUGFIX] Correct autosuggest when no result has been found

Markus Sommer CR +2 V +2 Easy +6 −0 updated 11/20/15, 13:15

Commit message

Normally, jQuery adds position:absolute to the autosuggest box. The
patch fixes this behaviour. That way, the autosuggest is displayed
correctly.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Björn Jacob +1
    • Oliver Eglseder +1
    • Michael Oehlhof +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Björn Jacob +1
    • Oliver Eglseder +1
    • Michael Oehlhof +1

Issues 1

Files 2

Review log 20

  1. Markus Sommer uploaded patch set 1 11/14/15, 13:53

  2. Markus Sommer updated the commit message in patch set 2 11/14/15, 13:55

  3. Björn Jacob commented on patch set 3 11/14/15, 16:57

    Published edit on patch set 2
  4. Björn Jacob commented on patch set 3 CR +1 V +1 11/14/15, 16:57

    Very nice.
  5. Oliver Eglseder voted on patch set 3 CR +1 V +1 11/14/15, 22:33

  6. Michael Oehlhof commented on patch set 3 11/15/15, 00:11

    Can't reproduce the bug with current master. In 7LTS it is still there. Don't know if this patch is really needed.
  7. Wouter Wolters commented on patch set 3 CR -1 11/15/15, 13:50

    _topbar.less:190

    inline styles
  8. Wouter Wolters uploaded patch set 4 11/15/15, 13:51

  9. Wouter Wolters commented on patch set 4 CR +1 V +1 11/15/15, 13:52

    reproducable by typing something that has no hits at all. If you have a result and than no results the view is correct.
  10. Stefan Neufeind commented on patch set 4 11/15/15, 15:41

    Tried to replicate the problem. But with the patch, turning the new !important rule on/off in FireBug didn't result in a difference as I expected. Hmm ...
  11. Björn Jacob commented on patch set 4 CR +1 V +1 11/15/15, 15:51

    Tested with current chrome. Problem can still be reproduced on Chrome, Opera and Firefox.
  12. Oliver Eglseder commented on patch set 4 CR +1 V +1 11/15/15, 17:47

    I can still reproduce this and the patch works fine
  13. Steffen Müller commented on patch set 4 11/15/15, 20:28

    Can't reproduce on latest chrome and firefox
  14. Daniel L commented on patch set 4 11/15/15, 20:55

    Can't reproduce the error on latest chromium and firefox (ubuntu 15.10). Patch has no effect.
  15. Marcus Schwemer commented on patch set 4 V -1 11/15/15, 21:10

    Cannot reproduce this too. Updated the issue in order to get more information about the environment. Until more info my -1, because there is probably no change.
  16. Björn Jacob commented on patch set 4 11/15/15, 21:19

    This little basta*d is quite annoying, isn't it...
  17. Michael Oehlhof voted on patch set 4 CR +1 V +1 11/15/15, 22:13

  18. Marcus Schwemer voted on patch set 4 V 0 11/20/15, 13:10

  19. Georg Ringer voted on patch set 4 CR +2 V +2 11/20/15, 13:15

  20. Gerrit merged patch set 4 11/20/15, 13:15