Review main Merged

44719[TASK] Use FlexFormService to convert FAL driver configuration

Oliver Eglseder CR +2 V +2 Easy +3 −8 updated 11/20/15, 10:55

Commit message

This replaces the custom FlexForm converting Method of the ResourceFactory
with a technically mature and more suitable method from FlexForm Service,
which allows multiple sheets in FlexForms, instead of just a flat structure.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Markus Sommer +1
  • Verified V +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Markus Sommer +1

Issues 1

Files 1

Review log 6

  1. Oliver Eglseder uploaded patch set 1 11/14/15, 18:00

  2. Georg Ringer voted on patch set 1 CR +1 V +1 11/14/15, 19:49

  3. Markus Sommer voted on patch set 1 CR +1 V +1 11/15/15, 19:46

  4. Stefan Neufeind voted on patch set 1 CR +1 V +1 11/20/15, 10:44

  5. Georg Ringer voted on patch set 1 CR +2 V +2 11/20/15, 10:55

  6. Gerrit merged patch set 1 11/20/15, 10:55