Review main Abandoned

44721[BUGFIX] Fix action uri handling in EXT:form

Carlos Meyer CR 0 V 0 Easy +1 −1 updated 03/03/16, 17:40

Commit message

Use actionUri instead of pageUid for user defined "action"

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 11

  1. Carlos Meyer uploaded patch set 1 11/14/15, 23:49

  2. Tomas Norre Mikkelsen voted on patch set 1 CR +1 11/15/15, 19:04

  3. Markus Sommer voted on patch set 1 CR +1 11/15/15, 19:16

  4. Markus Sommer voted on patch set 1 V +1 11/15/15, 19:16

  5. Steffen Müller voted on patch set 1 CR +1 V +1 11/15/15, 19:58

  6. Steffen Müller commented on patch set 2 11/15/15, 20:08

    Published edit on patch set 1
  7. Steffen Müller voted on patch set 2 CR +1 V +1 11/15/15, 20:08

  8. Steffen Müller commented on patch set 2 11/15/15, 20:08

    Updated commit message
  9. Björn Jacob commented on patch set 2 V -1 11/15/15, 21:08

    This change would be breaking compared to the behaviour of 6.2. With the rewrite we've tried to have maximal compatibility. With EXT:form 6.2 one could write "action=1". This was interpreted as pageUid. Have to think about this one again.
  10. Björn Jacob commented on patch set 2 11/15/15, 21:16

    I think actionUri should be used. I've added an example to the issue. Please try it out. Right now I do not have a current master running with realUrl installed.
  11. Benni Mack abandoned the change 03/03/16, 17:40

    see original issue why this patch won't go in.