Review TYPO3_6-2 Merged

44724[BUGFIX] Prevent deletion of closing bracket via INCLUDE_TYPOSCRIPT

Stefan Neufeind CR +2 V +2 Easy +2 −2 updated 11/21/15, 14:54

Commit message

Due to missing check of the last char being a new line, it is
possible that a closing bracket character is removed by
using INCLUDE_TYPOSCRIPT.
This leads to broken typoscript.
By introducing the missing check this kind of error is prevented.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Andreas Allacher +1
    • Martin Kutschker +1
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 7

  1. Stefan Neufeind uploaded patch set 1 11/15/15, 11:46

  2. Stefan Neufeind commented on patch set 1 11/15/15, 11:47

    as already merged in master
  3. Stefan Neufeind voted on patch set 1 CR +1 11/15/15, 11:48

  4. Andreas Allacher voted on patch set 1 CR +1 11/15/15, 13:32

  5. Martin Kutschker commented on patch set 1 CR +1 11/21/15, 14:16

    Seems to work fine for 7.x
  6. Markus Klein voted on patch set 1 CR +2 V +2 11/21/15, 14:54

  7. Gerrit merged patch set 1 11/21/15, 14:54