Review main Merged

44726[BUGFIX] Include CSS of AdminPanel only if shown

Georg Ringer CR +2 V +2 Easy +2 −1 updated 11/21/15, 15:17

Commit message

Include the CSS file only if the AdminPanel is rendered

Review

  • Code review CR +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Martin Kutschker +1
  • Verified V +2
    • Georg Ringer +2
    • Anja Leichsenring +1
    • Martin Kutschker +1
    • Gianluigi Martino +1

Issues 1

Files 2

Review log 13

  1. Georg Ringer uploaded patch set 1 11/15/15, 20:59

  2. Michael Oehlhof voted on patch set 1 CR +1 11/15/15, 21:56

  3. Andreas Kienast commented on patch set 1 V -1 11/16/15, 08:06

    I have disabled the admin panel by `config.admPanel = 0`, but the file is still included while the admin panel itself isn't rendered anymore.
  4. Georg Ringer uploaded patch set 2 11/19/15, 05:56

  5. Gianluigi Martino commented on patch set 2 V -1 11/19/15, 08:19

    i have this: Fatal error: Class 'TYPO3\CMS\Frontend\View\ExtensionManagementUtility' not found in /var/www/review.local.typo3.org/typo3_src/typo3/sysext/frontend/Classes/View/AdminPanelView.php on line 329 no typoscript config is set
  6. Anja Leichsenring commented on patch set 2 V -1 11/19/15, 15:32

    I second Andreas notice. File is still there, even if admPanel is not. The fatal I can't reproduce, this seems to be a caching issue.
  7. Anja Leichsenring commented on patch set 2 CR +1 V +1 11/19/15, 15:38

    sorry, I had a caching issue myself. Works as advertised.
  8. Josef Glatz voted on patch set 2 CR +1 11/20/15, 06:49

  9. Martin Kutschker commented on patch set 2 CR +1 V +1 11/21/15, 13:14

    works as advertized for me without fatal errors
  10. Gianluigi Martino voted on patch set 2 V +1 11/21/15, 15:08

  11. Wouter Wolters voted on patch set 2 CR +1 11/21/15, 15:17

  12. Georg Ringer voted on patch set 2 CR +2 V +2 11/21/15, 15:17

  13. Gerrit merged patch set 2 11/21/15, 15:17